Skip to content

Conversation

@steveloughran
Copy link
Contributor

This is the first step for on-demand operations: things recognize when they are using on-demand tables,
as do the tests.

Branch-3.2 patch; test run failing for unrelated changes to the AbstractS3GuardToolTestBase test suite,
which highlight that we have enough S3Guard changes in trunk it's time to backport one by one.

Contributed by Steve Loughran.

Change-Id: I44cf87a2bd253b78c2d0414e4be20e920027c980

@steveloughran
Copy link
Contributor Author

I got a failure in a test run. Unrelated to this patch (the fix is one of the predecessor patches to AbstractS3GuardToolTestBase), but rather than selectively pull in those changes, I'm going to backport a set of the s3guard ones in the same order as in trunk (excluding the openFile() stuff).

This will bring 3.2 close to 3.3

This is the first step for on-demand operations: things recognize when they are using on-demand tables,
as do the tests.

Branch-3.2 patch; test run failing for unrelated changes to the AbstractS3GuardToolTestBase test suite,
which highlight that we have enough S3Guard changes in trunk it's time to backport one by one.

Contributed by Steve Loughran.

Change-Id: I44cf87a2bd253b78c2d0414e4be20e920027c980
@steveloughran steveloughran force-pushed the s3/HADOOP-16118-DDB-on-demand-branch-3.2 branch from f950e4f to 3452d83 Compare April 12, 2019 01:08
@steveloughran
Copy link
Contributor Author

accidentally committed using the yetus email addr (still need to get an official ASF alias for that, so resubmitted)

@steveloughran steveloughran changed the title HADOOP-16118. S3Guard to support on-demand DDB tables. HADOOP-16118. S3Guard to support on-demand DDB tables (branch-3.2). Apr 20, 2019
@steveloughran
Copy link
Contributor Author

No Yetus run; will push as a .patch

bills when it is not.

Before DynamoDB On-Demand was introduced, autoscaling was the sole form
of dynamic scaling.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace:end of line

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 684 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ branch-3.2 Compile Tests _
-1 mvninstall 498 root in branch-3.2 failed.
-1 compile 26 hadoop-aws in branch-3.2 failed.
-0 checkstyle 10 The patch fails to run checkstyle in hadoop-aws
-1 mvnsite 13 hadoop-aws in branch-3.2 failed.
-1 shadedclient 220 branch has errors when building and testing our client artifacts.
-1 javadoc 12 hadoop-aws in branch-3.2 failed.
0 spotbugs 246 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 12 hadoop-aws in branch-3.2 failed.
_ Patch Compile Tests _
-1 mvninstall 10 hadoop-aws in the patch failed.
-1 compile 10 hadoop-aws in the patch failed.
-1 javac 10 hadoop-aws in the patch failed.
-0 checkstyle 8 The patch fails to run checkstyle in hadoop-aws
-1 mvnsite 10 hadoop-aws in the patch failed.
-1 whitespace 0 The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 shadedclient 281 patch has errors when building and testing our client artifacts.
-1 javadoc 12 hadoop-aws in the patch failed.
-1 findbugs 12 hadoop-aws in the patch failed.
_ Other Tests _
-1 unit 12 hadoop-aws in the patch failed.
+1 asflicense 26 The patch does not generate ASF License warnings.
1965
Subsystem Report/Notes
Docker Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/Dockerfile
GITHUB PR #731
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a2c8f57b22cb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision branch-3.2 / ae8ca70
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/branch-compile-hadoop-tools_hadoop-aws.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-731/out/maven-branch-checkstyle-hadoop-tools_hadoop-aws.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/branch-mvnsite-hadoop-tools_hadoop-aws.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/branch-javadoc-hadoop-tools_hadoop-aws.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-731/out/maven-patch-checkstyle-hadoop-tools_hadoop-aws.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/whitespace-eol.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-javadoc-hadoop-tools_hadoop-aws.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/testReport/
Max. process+thread count 84 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-731/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
This PR converts a hard-check that fails in case of regex-defined input if there is an overlap
between regex-input and task-input, to a warning.

Why?
Because with Samza 1.0, rewrite is called multiple times to expand system descriptors, input descriptors, etc. This hard-check fails in this case causing deployment to stall. Therefore we convert it to a warning.

NOTE: This now allows users to define stream config for their inputs which may overlap with regex-input. This was earlier explicitly disallowed by the hard-check.

Author: rmatharu@linkedin.com <rmatharu@linkedin.com>

Reviewers: Prateek Maheshwari <pmaheshwari@apache.org>

Closes apache#731 from rmatharu/regexcheck
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-3.2 Compile Tests _
+1 💚 mvninstall 20m 46s branch-3.2 passed
+1 💚 compile 0m 29s branch-3.2 passed
+1 💚 checkstyle 0m 22s branch-3.2 passed
+1 💚 mvnsite 0m 32s branch-3.2 passed
+1 💚 shadedclient 13m 8s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 25s branch-3.2 passed
+0 🆗 spotbugs 0m 53s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 51s branch-3.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 37s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
-0 ⚠️ checkstyle 0m 16s hadoop-tools/hadoop-aws: The patch generated 2 new + 17 unchanged - 1 fixed = 19 total (was 18)
+1 💚 mvnsite 0m 28s the patch passed
-1 ❌ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 shadedclient 13m 13s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 21s the patch passed
+1 💚 findbugs 1m 0s the patch passed
_ Other Tests _
+1 💚 unit 4m 33s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
60m 3s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/2/artifact/out/Dockerfile
GITHUB PR #731
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname Linux 61fe2bb8d732 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision branch-3.2 / cd5efe9
Default Java Private Build-1.8.0_252-8u252-b09-1~16.04-b09
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/2/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt
whitespace https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/2/artifact/out/whitespace-eol.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/2/testReport/
Max. process+thread count 461 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-3.2 Compile Tests _
+1 💚 mvninstall 31m 4s branch-3.2 passed
+1 💚 compile 0m 29s branch-3.2 passed
+1 💚 checkstyle 0m 25s branch-3.2 passed
+1 💚 mvnsite 0m 37s branch-3.2 passed
+1 💚 shadedclient 13m 37s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 27s branch-3.2 passed
+0 🆗 spotbugs 0m 57s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 55s branch-3.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 38s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
-0 ⚠️ checkstyle 0m 16s hadoop-tools/hadoop-aws: The patch generated 2 new + 17 unchanged - 1 fixed = 19 total (was 18)
+1 💚 mvnsite 0m 38s the patch passed
-1 ❌ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 shadedclient 16m 3s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 23s the patch passed
+1 💚 findbugs 0m 58s the patch passed
_ Other Tests _
-1 ❌ unit 4m 40s hadoop-aws in the patch failed.
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
86m 26s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/Dockerfile
GITHUB PR #731
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname Linux a138593e2a27 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / b5d24d6
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~16.04-b01
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt
whitespace https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/whitespace-eol.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/1/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/1/testReport/
Max. process+thread count 410 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-731/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor Author

abandoning; moot now you don't need s3guard no more

@steveloughran steveloughran deleted the s3/HADOOP-16118-DDB-on-demand-branch-3.2 branch October 15, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants