HDFS-17870: ArrayIndexOutOfBoundsException when DataNode was restarted without storageCapacities #8201
+42
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix for HDFS-17870
MiniDFSCluster.restartDataNode() throws ArrayIndexOutOfBoundsException when attempting to restart a DataNode that was added to the cluster without specifying storage capacities.
This bug is because MiniDFSCluster.setDataNodeStorageCapacities() did not validate that the DataNode index is within the bounds of the storageCapacities array before accessing it.
How was this patch tested?
In hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java add a new test method testRestartDataNodeWithoutStorageCapacities().
This test method will throw ArrayIndexOutOfBoundsException without the fix and pass with the fix.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html