HADOOP-19794: create-release version parsing incompatible with Java 17 #8210
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Remove the last step of the
sedparsing logic that attempted to break apart the older X.Y versioning convention (e.g. 1.8) and choose just the Y component (e.g. 8). This is no longer relevant for the newer versioning convention, e.g. Java 17.How was this patch tested?
I did a successful dry run of creating a 3.5.0 release after applying this patch.
Here is a transcript of how the chain of
sedoperations works on branch-3.4 vs. trunk. Notice that on trunk, the final step returns an empty result, which is why we need to remove it.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html