Skip to content

Conversation

@cnauroth
Copy link
Contributor

Description of PR

Remove the last step of the sed parsing logic that attempted to break apart the older X.Y versioning convention (e.g. 1.8) and choose just the Y component (e.g. 8). This is no longer relevant for the newer versioning convention, e.g. Java 17.

How was this patch tested?

I did a successful dry run of creating a 3.5.0 release after applying this patch.

Here is a transcript of how the chain of sed operations works on branch-3.4 vs. trunk. Notice that on trunk, the final step returns an empty result, which is why we need to remove it.

branch-3.4:
> grep "<javac.version>" "${BASEDIR}/hadoop-project/pom.xml" | head -1 | sed  -e 's|^ *<javac.version>||'
1.8</javac.version>

> grep "<javac.version>" "${BASEDIR}/hadoop-project/pom.xml" | head -1 | sed  -e 's|^ *<javac.version>||' -e 's|</javac.version>.*$||'
1.8

> grep "<javac.version>" "${BASEDIR}/hadoop-project/pom.xml" | head -1 | sed  -e 's|^ *<javac.version>||' -e 's|</javac.version>.*$||' -e 's|..||'
8

trunk:
> grep "<javac.version>" "${BASEDIR}/hadoop-project/pom.xml" | head -1 | sed  -e 's|^ *<javac.version>||'
17</javac.version>

> grep "<javac.version>" "${BASEDIR}/hadoop-project/pom.xml" | head -1 | sed  -e 's|^ *<javac.version>||' -e 's|</javac.version>.*$||'
17

> grep "<javac.version>" "${BASEDIR}/hadoop-project/pom.xml" | head -1 | sed  -e 's|^ *<javac.version>||' -e 's|</javac.version>.*$||' -e 's|..||'

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 22m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 8m 33s Maven dependency ordering for branch
+1 💚 shadedclient 27m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 shellcheck 0m 2s No new issues.
+1 💚 shadedclient 26m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
88m 9s
Subsystem Report/Notes
Docker ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8210/1/artifact/out/Dockerfile
GITHUB PR #8210
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs
uname Linux d8bf62b7decd 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 428f01e
Max. process+thread count 634 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8210/1/console
versions git=2.25.1 maven=3.9.11 shellcheck=0.7.0
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants