HBASE-24810: Download Boost with other dependencies #12
Conversation
|
(!) A patch to the testing environment has been detected. |
|
@joshelser @phrocker FYI With this change, all the tests pass for me locally since the boost dependency issue is fixed. Lets see what the precommit has to say. |
|
💔 -1 overall
This message was automatically generated. |
|
Looks like a g++ crash due to memory issue, especially after my last change that does a multi-threaded make. Let me try bumping up the docker mem limit.
|
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
cmake/boost/local/FindBoost.cmake
Outdated
|
|
||
| set(Boost_LIBRARIES "" CACHE STRING "" FORCE) | ||
| foreach(COMPONENT ${Boost_FIND_COMPONENTS}) | ||
| list(APPEND Boost_LIBRARIES "${BOOST_ROOT}/lib/${BYPRODUCT_PREFIX}boost_${COMPONENT}${BYPRODUCT_SHARED_SUFFIX}") |
There was a problem hiding this comment.
Given BYPRODUCT_SHARED_SUFFIX, will the install ensure these shared objects are available for the distributed binary?
There was a problem hiding this comment.
This was unintentional, the build was building both shared and static libs and hence this worked. Let me move to static libs.
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
Patch is ready for review.
After trying out a few make concurrency values, we finally have a working test run with 3 of 33 tests failing (they pass for me locally though) yay!!. I enabled failed test logging so that we have the test logs in the artifacts.
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
Wow! Lots of progress since I've last made some time. I was able to validate that building works from within the provided docker container (e.g. I'm guessing these are trying to talk to an HBase which I don't have running locally, so I'm not too concerned ;) |
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
Looks great to this c++ noob.
|
Thanks for taking a look @joshelser.
No, we do have an in-process mini cluster that runs via JNI (its a simple wrapper over the Java implementation). In my local setup all the tests pass for me. If it is not too much effort, can you please share the stdout of one of the failing tests? Thanks. |
|
@phrocker you have any more comments? I think I addressed your concerns but it'd be great if you can double check. Thanks. |
|
(!) A patch to the testing environment has been detected. |
|
Talked to Marc briefly today. He said he had a busy week, but he is meaning to come back and take a look. You're probably OK to move ahead if you have time to work on this, Bharath :) |
|
Thanks @joshelser. Let me merge this then. @phrocker I think we can revisit these pieces again once you rebase #6 on top of this patch. Eventually we need to make another pass over all the dependencies and make sure everything is being built with the right flags and linked correctly. For now I think this is in a decent shape and passing most tests, so getting this in. |
Signed-off-by: Josh Elser <elserj@apache.org>
…r mem limit Signed-off-by: Josh Elser <elserj@apache.org>
4 participants
No description provided.