apache · bharathv · May 21, 2020 · Jun 23, 2020 · Jun 23, 2020 · Jun 26, 2020
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -56,10 +56,12 @@ endif()
 ## include the Protobuf generation code
 include(ProtobufGen)
 include(DownloadBoost)
+include(DownloadFizz)
 include(DownloadFolly)
 include(DownloadWangle)
 include(DownloadZookeeper)
-
+include(DownloadCyrusSasl)
+include(DownloadDoubleConversion)
 set(PROJECT_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/dependencies")
 
 set(BOOST_MIN_VERSION "1.6.1")
@@ -82,16 +84,22 @@ if (DOWNLOAD_DEPENDENCIES)
 
   set(PROTOBUF_PROTOC_EXECUTABLE "${Protobuf_BINARY_DIR}/bin/protoc" CACHE STRING "" FORCE)
   ## Add CMAKE_MODULE_PATHS
-	
+
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/boost/local")
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/zookeeper/local")
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/protobuf/local")
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/folly/local")
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/wangle/local")
+  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/fizz/local")
+  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/sasl2/local")
+  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/doubleconversion/local")
 else()
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/zookeeper/system")
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/folly/system")
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/wangle/system")
+  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/fizz/system")
+  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/sasl2/system")
+  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/doubleconversion/system")
 endif(DOWNLOAD_DEPENDENCIES)
 
 ## Build Apache HBase components that are necessary for this project
@@ -136,9 +144,8 @@ if(COMPILER_SUPPORTS_CXX14)
 elseif(COMPILER_SUPPORTS_CXX0X)
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
 else()
-  message(FATAL_ERROR "The compiler ${CMAKE_CXX_COMPILER} has no c++14 support. Please use a different C++ compiler.")
+  message(FATAL_ERROR "The compiler ${CMAKE_CXX_COMPILER} does not have C++14 support. Please use a different C++ compiler.")
 endif()
-
 set(HBASE_SRC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/src/hbase")
 set(HBASE_PROTO_GEN_SRC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/src/hbase/if")
 set(HBASE_PROTO_GEN_INC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/include/hbase/if")
@@ -155,12 +162,13 @@ if (OPENSSL_FOUND)
 else ()
   message( FATAL_ERROR "OpenSSL was not found. Please install OpenSSL" )
 endif (OPENSSL_FOUND)
-## Download Facebook Folly and build locally
-
-
+## Download dependencies and build locally
 if (DOWNLOAD_DEPENDENCIES)
   download_boost(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} "${BOOST_LIBS}")
+  download_doubleconversion(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
+  download_cyrus_sasl(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
   download_folly(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
+  download_fizz(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
   download_wangle(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
   download_zookeeper(${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR})
 endif(DOWNLOAD_DEPENDENCIES)
@@ -173,6 +181,7 @@ find_package(LibEvent REQUIRED)
 find_package(Gflags REQUIRED)
 if (DOWNLOAD_DEPENDENCIES)
   find_package(Sodium REQUIRED)
+  find_package(Fizz REQUIRED)
 endif(DOWNLOAD_DEPENDENCIES)
 find_package(Folly REQUIRED)
 find_package(Krb5 REQUIRED)
@@ -206,7 +215,9 @@ include_directories(${Boost_INCLUDE_DIR})
 include_directories(${KRB5_INCLUDE_DIRS})
 include_directories(${JAVA_INCLUDE_DIRS})
 include_directories(${FOLLY_INCLUDE_DIR})
+include_directories(${FIZZ_INCLUDE_DIR})
 include_directories(${WANGLE_INCLUDE_DIR})
+include_directories(${DOUBLE_CONVERSION_INCLUDE_DIR})
 ### create a directory for the hbase protobuf headers.
 ### this is helpful so that when we include it, later, we can generate
 ### the protocol buffer source/headers without polluting our tree.
@@ -243,12 +254,9 @@ add_library(hbaseclient-static STATIC ${PROTO_SOURCES} ${CLIENT_SRC} ${CONNECTIO
 set_target_properties(hbaseclient-static PROPERTIES LINKER_LANGUAGE CXX)
 SET_TARGET_PROPERTIES(hbaseclient-static PROPERTIES OUTPUT_NAME hbaseclient CLEAN_DIRECT_OUTPUT 1)
 set_target_properties(hbaseclient-static PROPERTIES ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/libs")
-target_link_libraries(hbaseclient-static ${Boost_LIBRARIES})
-target_link_libraries(hbaseclient-static ${SASL_LIBS})
-target_link_libraries(hbaseclient-static ${GFLAGS_SHARED_LIB})
-target_link_libraries(hbaseclient-static ${KRB5_LIBRARIES})
 target_link_libraries(hbaseclient-static ${WANGLE_LIBRARIES})
 if (DOWNLOAD_DEPENDENCIES)
+  target_link_libraries(hbaseclient-static ${FIZZ_LIBRARIES})
   target_link_libraries(hbaseclient-static ${sodium_LIBRARY_RELEASE})
 endif(DOWNLOAD_DEPENDENCIES)
 target_link_libraries(hbaseclient-static ${FOLLY_LIBRARIES})
@@ -258,17 +266,21 @@ target_link_libraries(hbaseclient-static ${PROTOBUF_LIBRARY})
 target_link_libraries(hbaseclient-static ${DOUBLE_CONVERSION_LIBRARY})
 target_link_libraries(hbaseclient-static ${ZOOKEEPER_LIBRARIES})
 target_link_libraries(hbaseclient-static ${OPENSSL_LIBRARIES})
+target_link_libraries(hbaseclient-static ${Boost_LIBRARIES})
+target_link_libraries(hbaseclient-static ${SASL_LIBS})
+target_link_libraries(hbaseclient-static ${GFLAGS_SHARED_LIB})
+target_link_libraries(hbaseclient-static ${KRB5_LIBRARIES})
 target_link_libraries(hbaseclient-static ${CMAKE_DL_LIBS})
+target_link_libraries(hbaseclient-static ${CMAKE_THREAD_LIBS_INIT})
 
 add_library(hbaseclient-shared SHARED ${PROTO_SOURCES} ${CLIENT_SRC} ${CONNECTION_SRC} ${EXCEPTION_SRC} ${PROTO_SRC} ${SECURITY_SRC} ${SRDE_SRC} ${UTILS_SRC})
 set_target_properties(hbaseclient-shared PROPERTIES LINKER_LANGUAGE CXX)
 SET_TARGET_PROPERTIES(hbaseclient-shared PROPERTIES COMPILE_FLAGS " -fPIC")
 SET_TARGET_PROPERTIES(hbaseclient-shared PROPERTIES OUTPUT_NAME hbaseclient CLEAN_DIRECT_OUTPUT 1)
 set_target_properties(hbaseclient-shared PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/libs")
-target_link_libraries(hbaseclient-shared ${PROTOBUF_LIBRARY})
-target_link_libraries(hbaseclient-shared ${Boost_LIBRARIES})
 target_link_libraries(hbaseclient-shared ${WANGLE_LIBRARIES})
 if (DOWNLOAD_DEPENDENCIES)
+  target_link_libraries(hbaseclient-shared ${FIZZ_LIBRARIES})
   target_link_libraries(hbaseclient-shared ${sodium_LIBRARY_RELEASE})
 endif(DOWNLOAD_DEPENDENCIES)
 target_link_libraries(hbaseclient-shared ${FOLLY_LIBRARIES})
@@ -280,27 +292,19 @@ target_link_libraries(hbaseclient-shared ${OPENSSL_LIBRARIES})
 target_link_libraries(hbaseclient-shared ${LIB_EVENT_LIBRARY})
 target_link_libraries(hbaseclient-shared ${ZOOKEEPER_LIBRARIES})
 target_link_libraries(hbaseclient-shared ${DOUBLE_CONVERSION_LIBRARY})
+target_link_libraries(hbaseclient-shared ${PROTOBUF_LIBRARY})
+target_link_libraries(hbaseclient-shared ${Boost_LIBRARIES})
 target_link_libraries(hbaseclient-shared ${CMAKE_DL_LIBS})
+target_link_libraries(hbaseclient-static ${CMAKE_THREAD_LIBS_INIT})
+
 add_executable(simple-client "${HBASE_SRC_DIR}/examples/simple-client.cc")
 set_target_properties(simple-client PROPERTIES COMPILE_FLAGS "  ")
 set_target_properties(simple-client PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin/examples")
-target_link_libraries(simple-client ${PROTOBUF_LIBRARY})
-target_link_libraries(simple-client ${Boost_LIBRARIES})
-target_link_libraries(simple-client ${SASL_LIBS})
-target_link_libraries(simple-client ${GFLAGS_SHARED_LIB})
-target_link_libraries(simple-client ${KRB5_LIBRARIES})
-target_link_libraries(simple-client ${ZOOKEEPER_LIBRARIES})
-target_link_libraries(simple-client hbaseclient-static ${CMAKE_THREAD_LIBS_INIT})
+target_link_libraries(simple-client hbaseclient-static)
 add_executable(load-client "${HBASE_SRC_DIR}/examples/load-client.cc")
 set_target_properties(load-client PROPERTIES COMPILE_FLAGS "  ")
 set_target_properties(load-client PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin/examples")
-target_link_libraries(load-client ${PROTOBUF_LIBRARY})
-target_link_libraries(load-client ${Boost_LIBRARIES})
-target_link_libraries(load-client ${SASL_LIBS})
-target_link_libraries(load-client ${GFLAGS_SHARED_LIB})
-target_link_libraries(load-client ${KRB5_LIBRARIES})
-target_link_libraries(load-client ${ZOOKEEPER_LIBRARIES})
-target_link_libraries(load-client hbaseclient-static ${CMAKE_THREAD_LIBS_INIT})
+target_link_libraries(load-client hbaseclient-static)
 if (JNI_FOUND)
   message (STATUS "JNI_INCLUDE_DIRS=${JNI_INCLUDE_DIRS}")
   message (STATUS "JNI_LIBRARIES=${JNI_LIBRARIES}")
@@ -314,12 +318,21 @@ add_custom_target(
     COMMAND ${CMAKE_SOURCE_DIR}/bin/cpplint.sh)
 
 if (DOWNLOAD_DEPENDENCIES)
+  add_dependencies(hbaseclient-static Protobuf)
+  add_dependencies(hbaseclient-shared Protobuf)
+  ## everything relies on folly. fizz relies on folly. wangle
+  ## relies on folly and fizz
   add_dependencies(facebook-folly-proj boost)
   add_dependencies(hbaseclient-static boost)
   add_dependencies(hbaseclient-shared boost)
-  add_dependencies(hbaseclient-static Protobuf)
-  add_dependencies(hbaseclient-shared Protobuf)
+  add_dependencies(hbaseclient-static cyrussasl)
+  add_dependencies(hbaseclient-shared cyrussasl)
+  add_dependencies(facebook-folly-proj boost)
+  add_dependencies(facebook-folly-proj doubleconversion-proj)
   add_dependencies(facebook-wangle-proj facebook-folly-proj)
+  add_dependencies(facebook-fizz-proj facebook-folly-proj)
+  add_dependencies(facebook-wangle-proj facebook-folly-proj)	
+  add_dependencies(facebook-wangle-proj facebook-fizz-proj)
   add_dependencies(hbaseclient-static facebook-wangle-proj)
   add_dependencies(hbaseclient-shared facebook-wangle-proj)
   add_dependencies(hbaseclient-static zookeeper)

diff --git a/cmake/BuildTests.cmake b/cmake/BuildTests.cmake
@@ -39,32 +39,16 @@ target_include_directories(testutil PRIVATE BEFORE${Zookeeper_INCLUDE_DIRS})
 target_include_directories(testutil PRIVATE BEFORE${KRB5_INCLUDE_DIRS})
 target_include_directories(testutil PRIVATE BEFORE${Java_INCLUDE_DIRS})
 target_include_directories(testutil PRIVATE BEFORE${FOLLY_INCLUDE_DIRS})
-target_link_libraries(testutil hbaseclient-static ${CMAKE_THREAD_LIBS_INIT} ${Java_LIBRARIES} ${JNI_LIBRARIES} ${PROTOBUF_LIBRARY} ${Boost_LIBRARIES} ${GFLAGS_SHARED_LIB} ${GMOCK_SHARED_LIB} ${GTEST_BOTH_LIBRARIES} ${SASL_LIBS} ${GFLAGS_SHARED_LIB} ${KRB5_LIBRARIES} ${OPENSSL_LIBRARIES} ${Zookeeper_LIBRARIES})
+target_link_libraries(testutil hbaseclient-static ${CMAKE_THREAD_LIBS_INIT} ${CMAKE_DL_LIBS} ${Java_LIBRARIES} ${JNI_LIBRARIES} ${PROTOBUF_LIBRARY} ${Boost_LIBRARIES} ${GFLAGS_SHARED_LIB} ${GMOCK_SHARED_LIB} ${GTEST_BOTH_LIBRARIES} ${KRB5_LIBRARIES} ${SASL_LIBS} ${GFLAGS_SHARED_LIB} ${OPENSSL_LIBRARIES} ${Zookeeper_LIBRARIES})
 function(createTests testName)
-   message ("-- Including Test: ${testName}")
+   message (STATUS "Including Test: ${testName}")
     target_include_directories(${testName} PRIVATE BEFORE "include")
     target_include_directories(${testName} PRIVATE BEFORE "${Java_INCLUDE_DIRS}")
     target_include_directories(${testName} PRIVATE BEFORE "${JNI_INCLUDE_DIRS}")
     target_include_directories(${testName} PRIVATE BEFORE "${Boost_INCLUDE_DIR}")
     target_include_directories(${testName} PRIVATE BEFORE "${GTEST_INCLUDE_DIRS}")
     target_include_directories(${testName} PRIVATE BEFORE "${OPENSSL_INCLUDE_DIR}")
-
-
-    #target_link_libraries(${testName} ${PROTOBUF_LIBRARY})
-    #${PROTOBUF_LIBRARY}
-
-    target_link_libraries(${testName} hbaseclient-static testutil ${CMAKE_DL_LIBS} 
-    ${Java_LIBRARIES}
-    ${JNI_LIBRARIES}
-    ${Boost_LIBRARIES}
-    ${GFLAGS_SHARED_LIB}
-    ${GTEST_BOTH_LIBRARIES}
-    ${SASL_LIBS}
-    ${GFLAGS_SHARED_LIB}
-    ${KRB5_LIBRARIES}
-    ${ZOOKEEPER_LIBRARIES} ${OPENSSL_LIBRARIES}
-    ${GLOG_SHARED_LIB}
-    ${CMAKE_THREAD_LIBS_INIT})
+    target_link_libraries(${testName} testutil)
 endfunction()
 enable_testing(test)
 SET(TEST_DIR ${CMAKE_SOURCE_DIR}/src/test)

diff --git a/cmake/DownloadBoost.cmake b/cmake/DownloadBoost.cmake
@@ -49,4 +49,7 @@ function(download_boost SOURCE_DIR BUILD_DIR BOOST_LIBS)
      INSTALL_COMMAND ""
   )
   set(BOOST_ROOT ${BOOST_INSTALL_DIR} PARENT_SCOPE)
+  set(BOOST_INCLUDEDIR ${BOOST_ROOT}/include PARENT_SCOPE)
+  set(BOOST_LIBRARYDIR ${BOOST_ROOT}/lib PARENT_SCOPE)
+  set(Boost_FIND_COMPONENTS ${BOOST_LIBS} PARENT_SCOPE)
 endfunction(download_boost) 
diff --git a/cmake/DownloadCyrusSasl.cmake b/cmake/DownloadCyrusSasl.cmake
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+## Download Cyrus SASL
+## SOURCE_DIR is typically the cmake source directory
+## BINARY_DIR is the build directory, typically 'build'
+
+function(download_cyrus_sasl SOURCE_DIR BUILD_DIR)
+  ExternalProject_Add(
+    cyrussasl
+    URL "https://github.com/cyrusimap/cyrus-sasl/releases/download/cyrus-sasl-2.1.27/cyrus-sasl-2.1.27.tar.gz"
+    PREFIX "${BUILD_DIR}/dependencies"
+    SOURCE_DIR "${BUILD_DIR}/dependencies/cyrussasl-src"
+    BINARY_DIR ${BUILD_DIR}/dependencies/cyrussasl-src/
+    CONFIGURE_COMMAND ./configure --enable-static --with-pic --prefix=${BUILD_DIR}/dependencies/cyrussasl-install
+      "CFLAGS=-fPIC"
+      "CXXFLAGS=${CMAKE_CXX_FLAGS} -fPIC"
+  )
+  set(SASL2_DIR "${BUILD_DIR}/dependencies/cyrussasl-install/" CACHE STRING "" FORCE)
+endfunction(download_cyrus_sasl)
diff --git a/cmake/DownloadDoubleConversion.cmake b/cmake/DownloadDoubleConversion.cmake
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+## Download Double Conversion library. 
+## SOURCE_DIR is typically the cmake source directory
+function(download_doubleconversion SOURCE_DIR BUILD_DIR)
+
+  ExternalProject_Add(
+    doubleconversion-proj
+    PREFIX "${BUILD_DIR}/dependencies"
+    GIT_REPOSITORY "https://github.com/google/double-conversion.git"
+    GIT_TAG "b1d531bfb130e7149ffe24bb0f1c5c01f20c3a5f" ## Commit hash from master
+    SOURCE_DIR "${BUILD_DIR}/dependencies/doubleconversion-proj-src"
+    CMAKE_ARGS "-DCMAKE_INSTALL_PREFIX=${BUILD_DIR}/dependencies/doubleconversion-proj-install" -DCMAKE_POSITION_INDEPENDENT_CODE=ON "${BUILD_ARGS}")
+
+  set(DOUBLE_CONVERSION_ROOT_DIR "${BUILD_DIR}/dependencies/doubleconversion-proj-install" CACHE STRING "" FORCE)
+endfunction(download_doubleconversion) 
diff --git a/cmake/DownloadFizz.cmake b/cmake/DownloadFizz.cmake
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+## Download facebook's fizz library. 
+## SOURCE_DIR is typically the cmake source directory
+## BINARY_DIR is the build directory, typically 'build'
+
+function(download_fizz SOURCE_DIR BUILD_DIR)
+  ExternalProject_Add(
+    facebook-fizz-proj
+    GIT_REPOSITORY "https://github.com/facebookincubator/fizz.git"
+    PREFIX "${BUILD_DIR}/dependencies"
+    GIT_TAG "v2020.05.18.00"
+    SOURCE_DIR "${BUILD_DIR}/dependencies/facebook-fizz-proj-src"
+    PATCH_COMMAND ${CMAKE_COMMAND} -E copy "${CMAKE_CURRENT_SOURCE_DIR}/cmake/folly/local/FindFolly.cmake" ${BUILD_DIR}/dependencies/facebook-fizz-proj-src/fizz/cmake/
+      COMMAND ${CMAKE_COMMAND} -E copy "${CMAKE_CURRENT_SOURCE_DIR}/cmake/doubleconversion/local/FindDoubleConversion.cmake" ${BUILD_DIR}/dependencies/facebook-fizz-proj-src/fizz/cmake
+      COMMAND ${CMAKE_COMMAND} -E copy "${CMAKE_CURRENT_SOURCE_DIR}/cmake/boost/local/FindBoost.cmake" ${BUILD_DIR}/dependencies/facebook-fizz-proj-src/fizz/cmake
+      COMMAND patch ${BUILD_DIR}/dependencies/facebook-fizz-proj-src/fizz/CMakeLists.txt "${CMAKE_CURRENT_SOURCE_DIR}/cmake/patches/fizz.v2020.05.18.00.cmake" 
+    INSTALL_DIR "${BUILD_DIR}/dependencies/facebook-fizz-proj-install"
+    CONFIGURE_COMMAND ${CMAKE_COMMAND} -DBUILD_EXAMPLES=OFF -DCMAKE_CROSSCOMPILING=ON -DBUILD_TESTS=OFF -DBOOST_ROOT=${BOOST_ROOT} -DFOLLY_ROOT_DIR=${FOLLY_ROOT_DIR} -DDOUBLE_CONVERSION_ROOT_DIR=${DOUBLE_CONVERSION_ROOT_DIR} -DBYPRODUCT_PREFIX=${BYPRODUCT_PREFIX} -DBYPRODUCT_SUFFIX=${BYPRODUCT_SUFFIX} -DCMAKE_INSTALL_PREFIX:PATH=${BUILD_DIR}/dependencies/facebook-fizz-proj-install ${BUILD_DIR}/dependencies/facebook-fizz-proj-src/fizz # Tell CMake to use subdirectory as source.
+  )
+  set(FIZZ_ROOT_DIR "${BUILD_DIR}/dependencies/facebook-fizz-proj-install" CACHE STRING "" FORCE)
+endfunction(download_fizz)