Skip to content

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Feb 16, 2024

  • protobuf 3.25.2
  • guava 33.0.0-jre
  • commons-cli 1.6.0
  • jetty 9.4.54.v20240208
  • jersey 2.41
  • javassist 3.30.2-GA
  • jackson-jaxrs-json-provider 2.16.1

@Apache-HBase

This comment was marked as outdated.

@NihalJain
Copy link
Contributor

Hi @ndimiduk It would be great if we could compile hbase code setting hbase-thirdparty to snapshot changes of this PR to avoid any hiccups later on.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 0m 34s master passed
+1 💚 compile 0m 13s master passed
+1 💚 javadoc 0m 6s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 35s the patch passed
+1 💚 compile 0m 13s the patch passed
+1 💚 javac 0m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 6s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s root in the patch passed.
+1 💚 asflicense 0m 5s The patch does not generate ASF License warnings.
3m 9s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-112/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #112
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 3e32fc9d702c 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 GNU/Linux
Build tool maven
git revision master / a05ae5a
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-112/2/testReport/
Max. process+thread count 393 (vs. ulimit of 1000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-112/2/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

Hi @ndimiduk It would be great if we could compile hbase code setting hbase-thirdparty to snapshot changes of this PR to avoid any hiccups later on.

Indeed. I'm not sure that we have necessary hooks in the HBase PR for this, so I'm looking into it locally. It would be nice if there was a workflow for such a test using Jenkins/PRs.

@ndimiduk
Copy link
Member Author

I published a SNAPSHOT build of this change to Apache's maven repo. The PR against hbase is pointed at that version. For your reference.

@ndimiduk
Copy link
Member Author

I can't get a clean unit test run on any branch, with or without this change involved. Moving forward with the RC.

 * protobuf 3.25.2
 * guava 33.0.0-jre
 * commons-cli 1.6.0
 * jetty 9.4.54.v20240208
 * jersey 2.41
 * javassist 3.30.2-GA
 * jackson-jaxrs-json-provider 2.16.1

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@ndimiduk ndimiduk merged commit 249b3b9 into apache:master Feb 26, 2024
@ndimiduk ndimiduk deleted the 28374-bump-4.1.6 branch February 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants