HBASE-24373 Implement JvmMetrics in HBase instead of using the one in hadoop #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Copied the code in hadoop to hbase directly with the same package name, and also added some dummy log4j classes in hbase-logging, it basically worked when running UTs. But I'm afraid it may not work when starting a cluster, as in tests, maven will make sure that the classes from the project will be loaded before the dependency jars, but when starting a cluster, there is no guarantee which one will be loaded first... |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
busbey
reviewed
May 28, 2020
| * Just for making hadoop work without log4j | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public class Logger { |
Contributor
There was a problem hiding this comment.
This doesn't end up in our client facing artifacts right?
busbey
reviewed
May 28, 2020
| import org.apache.yetus.audience.InterfaceAudience; | ||
|
|
||
| /** | ||
| * Just for making hadoop work without log4j |
Contributor
There was a problem hiding this comment.
If these are for making Hadoop work, they should be in the hadoop-compat module?
Contributor
Author
|
Finally I found it really hard to force JVM to load a specific class when there are conflicts, one possible solution is to add a bootstrap jar but it does not work for java11? So the solution in #1708 is that, we still have log4j jar on classpath so hadoop is fine, and make sure that there is no slf4j-log4j12 jar on our classpath so all logs will go to log4j2. PTAL. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.