-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment on the JIRA
For comparison.
For comparison.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Adding Unit Tests.Make this configuration empty in hbase-default.xml , get values in hdfs-default.xml or hdfs-site.xml
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
hbase-common/src/test/java/org/apache/hadoop/hbase/TestHBaseConfiguration.java
Outdated
Show resolved
Hide resolved
Set the parameter "dfs.domain.socket.path" to null as well
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
joshelser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, great. I didn't look closely enough. Thanks for explaining!
|
This was submitted, reverted due to breaking tests, but then resubmitted after fixing those tests in #2878 |
Remove the default value for this parameter.