HBASE-25634 The client scan frequently exceeds the quota, which cause… #3030
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Mar 29, 2021
| } | ||
| if (!(t instanceof RpcThrottlingException)) { | ||
| callable.prepare(tries != 0); | ||
| } |
Contributor
There was a problem hiding this comment.
So, the idea here is that if we got an exception and we are retrying, do NOT reload cache if the exception was a because we were throttled?
This is a good idea. I wonder if there are other exceptions where we retry but do not need to reload the cache?
saintstack
reviewed
Mar 29, 2021
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Would a test be hard to add?
| @InterfaceAudience.Private | ||
| public static class ThrowableWithExtraContext { | ||
| private final Throwable throwable; | ||
| public final Throwable throwable; |
Contributor
There was a problem hiding this comment.
You don't think we need an accessor here?
SiCheng-Zheng
force-pushed
the
HBASE-25634-new
branch
from
cc18b1a to
30ef0f2
Compare
… meta table scan to be too high
SiCheng-Zheng
force-pushed
the
HBASE-25634-new
branch
from
30ef0f2 to
8b3dc69
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
gottagogottagoGxj
approved these changes
Jun 18, 2022
liuzhangqing
approved these changes
Jun 18, 2022
yuanheng
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s the meta table scan to be too high