Skip to content

HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera… #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Apache9 merged 1 commit into from
Dec 9, 2023
Merged

HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera… #5567

Apache9 merged 1 commit into from
Dec 9, 2023

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Dec 7, 2023

…tion could lead to ROLLEDBACK state be persisent to procedure store

@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
d81357a 
…tion could lead to ROLLEDBACK state be persisent to procedure store
@Apache9 Apache9 self-assigned this Dec 7, 2023
@Apache-HBase
Copy link

Apache-HBase commented Dec 7, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 11s master passed
+1 💚 compile 2m 38s master passed
+1 💚 checkstyle 0m 38s master passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 31s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 49s the patch passed
+1 💚 compile 2m 34s the patch passed
+1 💚 javac 2m 34s the patch passed
+1 💚 checkstyle 0m 35s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 10m 46s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 1m 3s patch has no errors when running spotless:check.
+1 💚 spotbugs 2m 11s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
36m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5567
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 933ace10f036 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 82 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Dec 7, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 7s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 11s master passed
+1 💚 compile 0m 54s master passed
+1 💚 shadedjars 5m 30s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 24s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 50s the patch passed
+1 💚 compile 0m 46s the patch passed
+1 💚 javac 0m 46s the patch passed
+1 💚 shadedjars 5m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s the patch passed
_ Other Tests _
+1 💚 unit 220m 17s hbase-server in the patch passed.
245m 41s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5567
Optional Tests javac javadoc unit shadedjars compile
uname Linux db51bcf3d6ab 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/testReport/
Max. process+thread count 4574 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Dec 7, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 53s master passed
+1 💚 compile 0m 51s master passed
+1 💚 shadedjars 5m 32s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 compile 0m 37s the patch passed
+1 💚 javac 0m 37s the patch passed
+1 💚 shadedjars 5m 6s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s the patch passed
_ Other Tests _
-1 ❌ unit 258m 25s hbase-server in the patch failed.
281m 12s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5567
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3e2b3d0541cc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/testReport/
Max. process+thread count 4694 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

GeorryHuang
GeorryHuang approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@GeorryHuang GeorryHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache-HBase
Copy link

Apache-HBase commented Dec 8, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 9s master passed
+1 💚 compile 2m 37s master passed
+1 💚 checkstyle 0m 36s master passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 43s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 45s the patch passed
+1 💚 compile 2m 35s the patch passed
+1 💚 javac 2m 35s the patch passed
+1 💚 checkstyle 0m 34s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 10m 56s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
35m 17s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5567
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 8db735b55fa8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Dec 8, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 49s master passed
+1 💚 compile 0m 45s master passed
+1 💚 shadedjars 5m 26s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 47s the patch passed
+1 💚 compile 0m 45s the patch passed
+1 💚 javac 0m 45s the patch passed
+1 💚 shadedjars 5m 27s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s the patch passed
_ Other Tests _
+1 💚 unit 218m 7s hbase-server in the patch passed.
241m 22s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5567
Optional Tests javac javadoc unit shadedjars compile
uname Linux 75e8ff4f0b72 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/testReport/
Max. process+thread count 4742 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Dec 8, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 40s master passed
+1 💚 compile 0m 35s master passed
+1 💚 shadedjars 5m 0s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 compile 0m 35s the patch passed
+1 💚 javac 0m 35s the patch passed
+1 💚 shadedjars 5m 1s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 20s the patch passed
_ Other Tests _
-1 ❌ unit 224m 40s hbase-server in the patch failed.
245m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5567
Optional Tests javac javadoc unit shadedjars compile
uname Linux 21c255cd19c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 6e421e9
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/testReport/
Max. process+thread count 4709 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 82a2ce1 into apache:master Dec 9, 2023
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
a253472 
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
a46f736 
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
276e083 
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
0d1ffbd 
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
218bde7 
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
kadirozde pushed a commit to kadirozde/hbase that referenced this pull request Jan 5, 2024
@Apache9 @kadirozde
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
804e8fe 
…tion could lead to ROLLEDBACK state be persisent to procedure store (apache#5567)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9 @petersomogyi
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
37dcb30 
…tion could lead to ROLLEDBACK state be persisent to procedure store (apache#5567)

Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
(cherry picked from commit a253472)
Change-Id: I3674501c0eb4a4fc9f1ae17283bf900474c3a3e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mymeiyi mymeiyi mymeiyi approved these changes

@GeorryHuang GeorryHuang GeorryHuang approved these changes

Assignees

@Apache9 Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9 @Apache-HBase @mymeiyi @GeorryHuang