HBASE-28665 WALs not marked closed when there are errors in closing WALs #6027

kiran-maturi · 2024-06-26T04:26:27Z

Apache-HBase · 2024-06-26T05:05:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 31s		branch-2.5 passed
+1 💚	compile	0m 38s		branch-2.5 passed
+1 💚	javadoc	0m 24s		branch-2.5 passed
+1 💚	shadedjars	5m 7s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 17s		the patch passed
+1 💚	compile	0m 39s		the patch passed
+1 💚	javac	0m 39s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed
+1 💚	shadedjars	5m 10s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	10m 31s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		30m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 2643838c9562 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `9330bf5`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/testReport/
Max. process+thread count	1731 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-26T05:08:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 51s		branch-2.5 passed
+1 💚	compile	0m 47s		branch-2.5 passed
+1 💚	javadoc	0m 26s		branch-2.5 passed
+1 💚	shadedjars	5m 0s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 44s		the patch passed
+1 💚	compile	0m 47s		the patch passed
+1 💚	javac	0m 47s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	5m 1s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	12m 36s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		32m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 0ae823d368dd 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `9330bf5`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/testReport/
Max. process+thread count	1596 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-26T05:10:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 14s		branch-2.5 passed
+1 💚	compile	2m 34s		branch-2.5 passed
+1 💚	checkstyle	0m 37s		branch-2.5 passed
+1 💚	spotbugs	1m 31s		branch-2.5 passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 48s		the patch passed
+1 💚	compile	2m 35s		the patch passed
+1 💚	javac	2m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 35s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	spotbugs	1m 38s		the patch passed
+1 💚	hadoopcheck	15m 9s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
-1 ❌	spotless	0m 36s		patch has 23 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		34m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux bd0d58a5307f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `9330bf5`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9

This is only for 2.5.x? Other branches are not affected?

kiran-maturi · 2024-06-26T15:22:05Z

@Apache9 This impacts other branches (branch-2.x) as well. I have started with 2.5 will create pull request for other branches as well. Please let me know if we need to start with any specific branch for 2.x

Apache-HBase · 2024-06-28T17:50:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 16s		branch-2.5 passed
+1 💚	compile	0m 40s		branch-2.5 passed
+1 💚	javadoc	0m 23s		branch-2.5 passed
+1 💚	shadedjars	5m 6s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s		the patch passed
+1 💚	compile	0m 39s		the patch passed
+1 💚	javac	0m 38s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed
+1 💚	shadedjars	5m 7s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	10m 34s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		29m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 4a020171c482 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a20ab24`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/testReport/
Max. process+thread count	1718 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-28T17:53:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 53s		branch-2.5 passed
+1 💚	compile	0m 53s		branch-2.5 passed
+1 💚	javadoc	0m 30s		branch-2.5 passed
+1 💚	shadedjars	5m 2s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 39s		the patch passed
+1 💚	compile	0m 54s		the patch passed
+1 💚	javac	0m 54s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed
+1 💚	shadedjars	4m 59s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	11m 40s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		32m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux fc70b62fa2b1 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a20ab24`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/testReport/
Max. process+thread count	1656 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-28T17:53:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 18s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 53s		branch-2.5 passed
+1 💚	compile	0m 47s		branch-2.5 passed
+1 💚	javadoc	0m 27s		branch-2.5 passed
+1 💚	shadedjars	5m 0s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s		the patch passed
+1 💚	compile	0m 49s		the patch passed
+1 💚	javac	0m 49s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	4m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	12m 43s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		32m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux f1033582d3fb 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a20ab24`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/testReport/
Max. process+thread count	1592 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-28T17:57:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 14s		branch-2.5 passed
+1 💚	compile	2m 37s		branch-2.5 passed
+1 💚	checkstyle	0m 36s		branch-2.5 passed
+1 💚	spotbugs	1m 34s		branch-2.5 passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 51s		the patch passed
+1 💚	compile	2m 36s		the patch passed
+1 💚	javac	2m 36s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 35s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	spotbugs	1m 41s		the patch passed
+1 💚	hadoopcheck	16m 40s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
-1 ❌	spotless	0m 48s		patch has 63 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		36m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux b48fccc0b15a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `a20ab24`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-29T20:51:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	0m 7s		Docker failed to build run-specific yetus/hbase:tp-11287}.

Subsystem	Report/Notes
GITHUB PR	#6027
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versions	git=2.25.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-29T20:51:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	0m 15s		Docker failed to build run-specific yetus/hbase:tp-12915}.

Subsystem	Report/Notes
GITHUB PR	#6027
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versions	git=2.25.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-29T20:51:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	0m 15s		Docker failed to build run-specific yetus/hbase:tp-26249}.

Subsystem	Report/Notes
GITHUB PR	#6027
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versions	git=2.25.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-30T00:29:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 23s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 16s		branch-2.5 passed
+1 💚	compile	0m 39s		branch-2.5 passed
+1 💚	javadoc	0m 23s		branch-2.5 passed
+1 💚	shadedjars	5m 9s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s		the patch passed
+1 💚	compile	0m 40s		the patch passed
+1 💚	javac	0m 40s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed
+1 💚	shadedjars	5m 11s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	196m 36s		hbase-server in the patch passed.
		219m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6f3b08969c28 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `5cbb2f2`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/testReport/
Max. process+thread count	4120 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-30T00:32:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	0m 11s		Docker failed to build run-specific yetus/hbase:tp-22459}.

Subsystem	Report/Notes
GITHUB PR	#6027
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versions	git=2.25.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-30T00:32:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	0m 16s		Docker failed to build run-specific yetus/hbase:tp-1157}.

Subsystem	Report/Notes
GITHUB PR	#6027
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versions	git=2.25.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-30T01:13:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	4m 6s		branch-2.5 passed
+1 💚	compile	2m 56s		branch-2.5 passed
+1 💚	checkstyle	0m 42s		branch-2.5 passed
+1 💚	spotbugs	1m 45s		branch-2.5 passed
+1 💚	spotless	0m 50s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 19s		the patch passed
+1 💚	compile	2m 50s		the patch passed
+1 💚	javac	2m 50s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 42s		the patch passed
+1 💚	spotbugs	1m 58s		the patch passed
+1 💚	hadoopcheck	18m 21s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	spotless	0m 53s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		41m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux c8565aa24e60 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `3b29094`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-30T04:10:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 20s		branch-2.5 passed
+1 💚	compile	0m 39s		branch-2.5 passed
+1 💚	javadoc	0m 22s		branch-2.5 passed
+1 💚	shadedjars	5m 11s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 23s		the patch passed
+1 💚	compile	0m 39s		the patch passed
+1 💚	javac	0m 39s		the patch passed
+1 💚	javadoc	0m 24s		the patch passed
+1 💚	shadedjars	5m 10s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	196m 58s		hbase-server in the patch passed.
		218m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6027
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 8b1c867bacd6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `3b29094`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/testReport/
Max. process+thread count	4018 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

kiran-maturi · 2024-07-01T04:43:07Z

@virajjasani @apurtell can you please help with the review

virajjasani

Changes look good, master branch does not check for unflushed entries anymore. @Apache9 is it because of HBASE-27231?

virajjasani · 2024-07-02T00:23:51Z

@kiran-maturi could you please create PR against branch-2? From branch-2, we can backport to both 2.6 and 2.5 cleanly. Since this PR is already opened, 2.5 is already covered but usually branch-2 PR is required to run all tests.

ranganathg · 2024-07-02T09:43:05Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java

            closeWriter(this.writer, oldPath, true);
          } finally {
            inflightWALClosures.remove(oldPath.getName());
+            if (!isUnflushedEntries()) {


Similar to the code below at line 403, should we also have a catch block to Log a WARNING?
Does it make any difference to first remove old path and then call markCloseAndClean or vice versa? Since the JIRA said we are trying to follow the similar as below, we can try to keep it same?

Just another question, does closeWriter also flush?

@ranganathg inflightWALClosures.remove(oldPath.getName()); was there previously as well so not changing the behaviour there. We are explicitly looking for the closing for cleanup

Just another question, does closeWriter also flush?

No, this is in the write path it will not trigger any flush

@ranganathg sorry I got confused with the flush for region. If you are asking for flush for the entries that are there on the ringbuffer that will be done by the sycn runner threads which will increment the sequenceId

virajjasani · 2024-07-11T06:01:37Z

Merged changes to branch-2 and branch-2.6, let me merge this PR now.

HBASE-28665 WALs not marked closed when there are errors in closing WALs

9330bf5

Apache9 reviewed Jun 26, 2024

View reviewed changes

kiran-maturi marked this pull request as draft June 26, 2024 15:19

added test case

a20ab24

kiran-maturi force-pushed the HBASE-28665 branch from cc950f6 to a20ab24 Compare June 29, 2024 20:39

Kiran Kumar Maturi added 2 commits June 30, 2024 02:16

fixed test cases

8ee3e40

fixed log message

5cbb2f2

spotless fixes

3b29094

kiran-maturi marked this pull request as ready for review June 29, 2024 20:55

virajjasani self-requested a review July 1, 2024 19:07

virajjasani reviewed Jul 2, 2024

View reviewed changes

ranganathg reviewed Jul 2, 2024

View reviewed changes

virajjasani merged commit edda2d2 into apache:branch-2.5 Jul 11, 2024

HBASE-28665 WALs not marked closed when there are errors in closing WALs #6027

HBASE-28665 WALs not marked closed when there are errors in closing WALs #6027

Uh oh!

Conversation

kiran-maturi commented Jun 26, 2024 • edited by virajjasani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Jun 26, 2024

Uh oh!

Apache-HBase commented Jun 26, 2024

Uh oh!

Apache-HBase commented Jun 26, 2024

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

kiran-maturi commented Jun 26, 2024

Uh oh!

Apache-HBase commented Jun 28, 2024

Uh oh!

Apache-HBase commented Jun 28, 2024

Uh oh!

Apache-HBase commented Jun 28, 2024

Uh oh!

Apache-HBase commented Jun 28, 2024

Uh oh!

Apache-HBase commented Jun 29, 2024

Uh oh!

Apache-HBase commented Jun 29, 2024

Uh oh!

Apache-HBase commented Jun 29, 2024

Uh oh!

Apache-HBase commented Jun 30, 2024

Uh oh!

Apache-HBase commented Jun 30, 2024

Uh oh!

Apache-HBase commented Jun 30, 2024

Uh oh!

Apache-HBase commented Jun 30, 2024

Uh oh!

Apache-HBase commented Jun 30, 2024

Uh oh!

kiran-maturi commented Jul 1, 2024

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Jul 2, 2024

Uh oh!

ranganathg Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

ranganathg Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

kiran-maturi Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kiran-maturi Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Jul 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kiran-maturi commented Jun 26, 2024 •

edited by virajjasani

Loading

kiran-maturi Jul 2, 2024 •

edited

Loading