Skip to content

Conversation

@deniskuzZ
Copy link
Member

@deniskuzZ deniskuzZ commented Jul 9, 2025

steps updated after HMS received a proper packaging

@deniskuzZ deniskuzZ requested a review from zhangbutao July 9, 2025 09:42
@zhangbutao
Copy link
Contributor

@deniskuzZ I want to double check the included jars.
Before apache/hive#5923, the standalone hms package included the two jars:

hive-iceberg-catalog-4.1.0.jar
hive-iceberg-shading-4.1.0jar

After apache/hive#5923, the two jars was gone. Is this a expected behavior?
https://github.com/apache/hive/blob/d7b3a5ba4a6d3c4ea894fd36d0fc7e1f87a53e64/standalone-metastore/packaging/pom.xml#L185-#L190

@deniskuzZ
Copy link
Member Author

deniskuzZ commented Jul 9, 2025

@deniskuzZ I want to double check the included jars. Before apache/hive#5923, the standalone hms package included the two jars:

hive-iceberg-catalog-4.1.0.jar
hive-iceberg-shading-4.1.0jar

After apache/hive#5923, the two jars was gone. Is this a expected behavior? https://github.com/apache/hive/blob/d7b3a5ba4a6d3c4ea894fd36d0fc7e1f87a53e64/standalone-metastore/packaging/pom.xml#L185-#L190

only hive-iceberg-handler is needed !
see https://github.com/apache/hive/pull/5923/files#diff-a9f6d188c73de7e41dc426ba726842c02de647f4b2470238a2dc4a1aa243d724R181-R208

at some point we should rename it to hive-iceberg-runtime, that is how it was called in Iceberg project before they dropped it in favour of Hive's iceberg-handler

Copy link
Contributor

@zhangbutao zhangbutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Thanks!

@deniskuzZ deniskuzZ merged commit 514c15f into main Jul 10, 2025
@deniskuzZ deniskuzZ deleted the hms-release branch July 10, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants