HIVE-25528: Don't review yet #2712
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Jan 9, 2023
This also adds a test that makes sure a CharSequenceSet doesn't suffer from undefined equality behavior as reported by https://errorprone.info/bugpattern/CollectionUndefinedEquality
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Jan 19, 2023
InvisibleProgrammer
pushed a commit
to InvisibleProgrammer/hive
that referenced
this pull request
Feb 14, 2023
This also adds a test that makes sure a CharSequenceSet doesn't suffer from undefined equality behavior as reported by https://errorprone.info/bugpattern/CollectionUndefinedEquality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?