Skip to content

HIVE-26765: Hive Ranger URL policy for insert overwrite directory den… #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szlta merged 1 commit into from
Nov 21, 2022
Merged

HIVE-26765: Hive Ranger URL policy for insert overwrite directory den… #3790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3487,7 +3487,9 @@ public static enum ConfVars {
"When true it URL encodes the URI generated by HBaseStorageHandler for authorization. The URI consists of the" +
"HBase table name, column family, etc. and may contain characters that need encoding, such as #. If set to " +
"true, the corresponding Ranger policies need to be in URL encoded format too."),

HIVE_RANGER_USE_FULLY_QUALIFIED_URL("hive.ranger.use.fully.qualified.url", true, "When set to true, fully " +
"qualified path will be used to validate against ranger url policies. When set to false relative path is used." +
"Cannot be modified at runtime."),
// For Kudu storage handler
HIVE_KUDU_MASTER_ADDRESSES_DEFAULT("hive.kudu.master.addresses.default", "localhost:7050",
"Comma-separated list of all of the Kudu master addresses.\n" +
Expand Down
3 changes: 2 additions & 1 deletion ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7850,7 +7850,8 @@ protected Operator genFileSinkPlan(String dest, QB qb, Operator input)
loadFileDesc.setMoveTaskId(moveTaskId);
loadFileWork.add(loadFileDesc);
try {
Path qualifiedPath = destinationPath.getFileSystem(conf).makeQualified(destinationPath);
Path qualifiedPath = conf.getBoolVar(ConfVars.HIVE_RANGER_USE_FULLY_QUALIFIED_URL) ?
destinationPath.getFileSystem(conf).makeQualified(destinationPath) : destinationPath;
if (!outputs.add(new WriteEntity(qualifiedPath, !isDfsDir, isDestTempFile))) {
throw new SemanticException(ErrorMsg.OUTPUT_SPECIFIED_MULTIPLE_TIMES
.getMsg(destinationPath.toUri().toString()));
Expand Down
10 changes: 10 additions & 0 deletions ql/src/test/queries/clientpositive/fully_qualified_or_relative_location.q
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--! qt:dataset:src

SET hive.insert.into.multilevel.dirs=true;
SET hive.output.file.extension=.txt;

set hive.ranger.use.fully.qualified.url = true;
INSERT OVERWRITE DIRECTORY 'target/data/x/y/z/' SELECT src.* FROM src;

set hive.ranger.use.fully.qualified.url = false;
INSERT OVERWRITE DIRECTORY 'target/data/x/y/z/' SELECT src.* FROM src;
16 changes: 16 additions & 0 deletions ql/src/test/results/clientpositive/llap/fully_qualified_or_relative_location.q.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
PREHOOK: query: INSERT OVERWRITE DIRECTORY 'target/data/x/y/z/' SELECT src.* FROM src
PREHOOK: type: QUERY
PREHOOK: Input: default@src
#### A masked pattern was here ####
POSTHOOK: query: INSERT OVERWRITE DIRECTORY 'target/data/x/y/z/' SELECT src.* FROM src
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src
#### A masked pattern was here ####
PREHOOK: query: INSERT OVERWRITE DIRECTORY 'target/data/x/y/z/' SELECT src.* FROM src
PREHOOK: type: QUERY
PREHOOK: Input: default@src
PREHOOK: Output: target/data/x/y/z
POSTHOOK: query: INSERT OVERWRITE DIRECTORY 'target/data/x/y/z/' SELECT src.* FROM src
POSTHOOK: type: QUERY
POSTHOOK: Input: default@src
POSTHOOK: Output: target/data/x/y/z