HIVE-28208: WITH column list doesn't work with CTE materialization #5232
Conversation
okumin
force-pushed
the
HIVE-28208-cte-mat-column-list
branch
from
54e45a8 to
1fdc90a
Compare
| if (columns != null) { | ||
| FieldSchema col = new FieldSchema(); | ||
| if (!("".equals(nm[0])) && nm[1] != null) { | ||
| if (i < withColList.size()) { |
There was a problem hiding this comment.
Using an input name when is shorter than the input. This follows the behavior of non-materialized CTEs.
If I understand correctly, with-column-list is supported only when the number of columns is exactly equal to that of the query expression. So, it could be an option to disallow colInfos.size() != withColList.size().
| set hive.optimize.cte.materialize.threshold=2; | ||
| set hive.optimize.cte.materialize.full.aggregate.only=false; | ||
| -- Use a format that retains column names | ||
| set hive.default.fileformat=parquet; |
There was a problem hiding this comment.
The default one positionally accesses physical columns, and we can't find some kinds of errors.
okumin
force-pushed
the
HIVE-28208-cte-mat-column-list
branch
from
1fdc90a to
cb96aaf
Compare
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
okumin
force-pushed
the
HIVE-28208-cte-mat-column-list
branch
from
cb96aaf to
ef9d834
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
okumin
force-pushed
the
HIVE-28208-cte-mat-column-list
branch
from
ef9d834 to
0bd086e
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
|
|
cc @zabetak |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
3 participants
What changes were proposed in this pull request?
ANSI SQL supports column aliases for CTEs. Hive also supports it but it fails when CTEs are materialized.
https://issues.apache.org/jira/browse/HIVE-28208
Why are the changes needed?
This patch allows materialized CTEs to obey the standard.
Does this PR introduce any user-facing change?
No. The affected queries never succeed now.
Is the change a dependency upgrade?
No.
How was this patch tested?
I added test queries to
cte_mat_1.q.