Skip to content

Conversation

@deniskuzZ
Copy link
Member

@deniskuzZ deniskuzZ commented Dec 15, 2025

What changes were proposed in this pull request?

  • Added support for shredding VARIANT fields in structs, excluding VARIANT data stored inside arrays or maps;
  • Changed sampling strategy to first not-null value;
  • Removed patched Parquet.java, used reflection as a workaround;

Why are the changes needed?

Improved usability

Does this PR introduce any user-facing change?

No

How was this patch tested?

TestHiveIcebergVariant.java

@deniskuzZ deniskuzZ force-pushed the HIVE-29287_addendum branch 2 times, most recently from bd3a146 to 39f4ab6 Compare December 15, 2025 13:32
@deniskuzZ deniskuzZ requested a review from ayushtkn December 15, 2025 14:42
@deniskuzZ deniskuzZ force-pushed the HIVE-29287_addendum branch 4 times, most recently from fca9468 to f90a77d Compare December 15, 2025 19:40
@sonarqubecloud
Copy link

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deniskuzZ deniskuzZ merged commit ee7138b into apache:master Dec 17, 2025
4 checks passed
@deniskuzZ
Copy link
Member Author

thanks for the feedback & review, @ayushtkn !

DanielZhu58 pushed a commit to DanielZhu58/hive that referenced this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants