HIVE-22194 Break up DDLSemanticAnalyzer - extract Privilege related analyzers #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamachor
reviewed
Sep 12, 2019
...c/java/org/apache/hadoop/hive/ql/ddl/privilege/role/showcurrent/ShowCurrentRoleAnalyzer.java
Show resolved
Hide resolved
jcamachor
reviewed
Sep 12, 2019
| import org.apache.hadoop.hive.ql.ddl.privilege.role.set.SetRoleDesc; | ||
| import org.apache.hadoop.hive.ql.ddl.privilege.role.show.ShowRolesDesc; | ||
| import org.apache.hadoop.hive.ql.ddl.privilege.role.showcurrent.ShowCurrentRoleDesc; | ||
| import org.apache.hadoop.hive.ql.ddl.privilege.show.grant.ShowGrantDesc; |
Contributor
There was a problem hiding this comment.
Maybe we can merge them under show package (but not too strongly opinionated about it, up to you).
Contributor
Author
There was a problem hiding this comment.
Not sure what are you suggesting to be merged under the show packege. The HiveAuthorizationTaskFactoryImpl? Or role.show -> show.role?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor it in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
Step #2: extract all the privilege related analyzers from DDLSemanticAnalyzer, and move them under the new package.