HIVE-22276 Break up DDLSemanticAnalyzer - extract View related analyzers #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamachor
reviewed
Oct 13, 2019
Contributor
jcamachor
left a comment
jcamachor
left a comment
There was a problem hiding this comment.
I left some minor comments. It looks good overall. It needs rebasing after HIVE-21344 went in.
| static { | ||
| Set<Class<? extends BaseSemanticAnalyzer>> analyzerClasses = | ||
| Set<Class<? extends BaseSemanticAnalyzer>> analyzerClasses1 = | ||
| new Reflections("org.apache.hadoop.hive.ql.ddl").getSubTypesOf(BaseSemanticAnalyzer.class); |
Contributor
There was a problem hiding this comment.
Can we have this String as private static final at the class level?
| public AlterMaterializedViewRewriteDesc(String fqMaterializedViewName, boolean rewriteEnable) { | ||
| this.fqMaterializedViewName = fqMaterializedViewName; | ||
| public AlterMaterializedViewRewriteDesc(String materializedViewName, boolean rewriteEnable) { | ||
| this.materializedViewName = materializedViewName; |
Contributor
There was a problem hiding this comment.
Can we add a comment stating that it is the fully qualified name?
Contributor
Author
There was a problem hiding this comment.
Put back the fq prefix.
ql/src/test/results/clientnegative/materialized_view_no_transactional_rewrite_2.q.out
Outdated
Show resolved
Hide resolved
miklosgergely
force-pushed
the
HIVE-22276
branch
from
33b8910 to
f6bfb27
Compare
jcamachor
reviewed
Oct 14, 2019
|
|
||
| import com.google.common.annotations.VisibleForTesting; | ||
|
|
||
| import avro.shaded.com.google.common.collect.Sets; |
Contributor
There was a problem hiding this comment.
We should not use the shaded version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor it in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
Step #6: extract all the vire related analyzers from DDLSemanticAnalyzer, and move them under the new package.