Fix variable declaration after statement warning in scoreboard.c #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The C99 specification was released over 25 years ago! Why is Apache still enforcing C89/C90 semantics? An embedded system with an ancient compiler is probably not going to go using Apache 2.4. It theoretically could use Apache 1.4, but more likely would use a different modern web server with lower resource consumption than Apache 2.4. |
Collaborator
|
@gstrauss httpd has a very high inertia :) We discussed on dev@ recently that for 2.5.x we could move to a more modern C standard, I'm definitely in favour of it. |
Collaborator
|
Thanks for the PR @jajik |
Contributor
|
Thanks for merging, @notroj ! |
asfgit
pushed a commit
that referenced
this pull request
Jun 4, 2025
Fix variable declaration warning in scoreboard.c Submitted by: Vladimír Chlup <vchlup redhat.com> Github: closes #516 Reviewed by: rpluem, jorton, ylavic git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1926108 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest commit broke compilation with maintainer mode (the warning is treated as an error) incl. some jobs in CI.
https://github.com/apache/httpd/actions/runs/13282453047/job/37083598064
This PR fixes it.
https://github.com/jajik/httpd/actions/runs/13311390743