Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

refact: address some code alert#115

Merged
imbajin merged 6 commits intomasterfrom
fix-style
Nov 9, 2022
Merged

refact: address some code alert#115
imbajin merged 6 commits intomasterfrom
fix-style

Conversation

@imbajin
Copy link
Copy Markdown
Member

@imbajin imbajin commented Nov 4, 2022

this PR address all the warning from check-code-style plugin's

Other contributors could also handle them (just run maven compile and check the warning message) like below:

image

TODO: fix it also in toolchain/server

@imbajin imbajin requested review from corgiboygsj and zyxxoo November 4, 2022 12:30
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2022

Codecov Report

Merging #115 (68bbfa3) into master (952975a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #115   +/-   ##
=========================================
  Coverage     93.15%   93.15%           
  Complexity       65       65           
=========================================
  Files             9        9           
  Lines           263      263           
  Branches         22       22           
=========================================
  Hits            245      245           
  Misses            8        8           
  Partials         10       10           
Impacted Files Coverage Δ
...n/java/org/apache/hugegraph/config/RpcOptions.java 97.22% <ø> (ø)
...va/org/apache/hugegraph/rpc/RpcClientProvider.java 90.90% <ø> (ø)
...va/org/apache/hugegraph/rpc/RpcConsumerConfig.java 91.48% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment on lines +417 to +422
private static MediaType parseCustomContentType(MultivaluedMap<String, Object> headers) {
String customContentType = null;
if (MapUtils.isNotEmpty(headers) && headers.get("Content-Type") != null) {
Object contentTypeObj = headers.get("Content-Type");
if (contentTypeObj instanceof List) {
customContentType = ((List<?>) contentTypeObj).get(0).toString();
List<?> contentTypeObj = headers.get("Content-Type");
if (contentTypeObj != null && !contentTypeObj.isEmpty()) {
customContentType = contentTypeObj.get(0).toString();
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address the #113 here

javeme
javeme previously approved these changes Nov 4, 2022
@imbajin imbajin merged commit caa4b26 into master Nov 9, 2022
@imbajin imbajin deleted the fix-style branch November 9, 2022 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants