Skip to content

refine rest-server.property documentation#368

Merged
imbajin merged 4 commits intoapache:masterfrom
Thespica:refine-port-doc
Aug 2, 2024
Merged

refine rest-server.property documentation#368
imbajin merged 4 commits intoapache:masterfrom
Thespica:refine-port-doc

Conversation

@Thespica
Copy link
Copy Markdown
Contributor

@Thespica Thespica commented Aug 1, 2024

Purpose of the PR

refine rest-server.property documentation

related to apache/hugegraph#2610

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 1, 2024
Comment on lines +157 to +158
# http://0.0.0.0:8080 to listen all network interfaces, but need to take care of security
# or listen to specific IP with port
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with server

```

- restserver.url:RestServer 提供服务的 url,根据实际环境修改;
- restserver.url:RestServer 提供服务的 url,根据实际环境修改。如果其他 IP 地址无法访问,可以尝试修改为特定的地址;或修改为 `http://0.0.0.0:8080` 来监听来自任何 IP 地址的请求,这种方案较为便捷,但安全性有所缺失
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无需携带端口, 或者 http/https, 只和 ip 有关

另外"安全性有所缺失" -> "需要留意服务可被访问的网络范围"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync with CN version (could also update in hubble's doc?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default bind for hubble's config is 0.0.0.0, so I think user wouldn't meet this problem about accessing, mean while developers do not need to limit the accessibility of hubble.

So I think hubble does not need extra explanation.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 2, 2024
@imbajin imbajin merged commit 6f24080 into apache:master Aug 2, 2024
github-actions bot pushed a commit to zoroqi/incubator-hugegraph-doc that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants