Conversation
TODO: could we use one param to unify it? or use a action template reduce useless log
i can try to slove: is it ok? |
fine, but step3 need wait for server done, the 1,2 step are now blocking the merge process (The first one is not troublesome. You can try it 😃 ) |
| wget "${HUGEGRAPH_LINK}" || exit 1 | ||
| tar -zxvf hugegraph-${VERSION}.tar.gz | ||
| # TODO: lack incubator after apache package release (update it later) | ||
| tar zxvf hugegraph-${VERSION}.tar.gz |
There was a problem hiding this comment.
we can define an env var for it like PACKAGE_PREFIX="incubator-hugegraph"
There was a problem hiding this comment.
@z7658329 you could also do it in the next PR (and the next comment below, the priority is low now)
| cd ../ | ||
| rm -rf hugegraph | ||
| tar -zxvf hugegraph-*.tar.gz | ||
| tar zxvf hugegraph-*.tar.gz |
There was a problem hiding this comment.
update "hugegraph-*" like the script in hugegraph server
Co-authored-by: imbajin <jin@apache.org>
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=============================================
- Coverage 67.43% 38.92% -28.52%
- Complexity 878 966 +88
=============================================
Files 86 242 +156
Lines 4029 8111 +4082
Branches 477 719 +242
=============================================
+ Hits 2717 3157 +440
- Misses 1107 4775 +3668
+ Partials 205 179 -26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@simon824 seems the hubble CI failed due to some reason, could u take a look with it? If it's hard to fix quickly, we could merge this PR firstly to avoid suspend other PRs |
|
@imbajin It seems that the npm source address cannot be found, it may happen by accident, have you tried rerunning ci? |
sure,try rerun it 3 times,and the other PR didnt have this problem?(cache? skip the real build?) |
* fix parent artifactId env * fix parent artifactId env v2
|
After all ci pass,merge it first,then handle the ignore test in separate PR (like apache/hugegraph-commons#113) |



now we have some problems to solve: (TODO)
PS: could we use one commit ID to unify the CI? or use a action template