Skip to content

chore: update some params to fix CI error#339

Merged
zyxxoo merged 15 commits intomasterfrom
fix-ci
Nov 1, 2022
Merged

chore: update some params to fix CI error#339
zyxxoo merged 15 commits intomasterfrom
fix-ci

Conversation

@imbajin
Copy link
Copy Markdown
Member

@imbajin imbajin commented Oct 20, 2022

now we have some problems to solve: (TODO)

  1. we need adopt/update the config path for server(master) first (due to we support multi graph in 0.13, and the dir tree changed)
  2. we need update the client's APIVersion to meet the check (like CI in loader)
  3. last, after the server changed version to apache 1.0, we should also adapt it (later)

PS: could we use one commit ID to unify the CI? or use a action template

TODO: could we use one param to unify it? or use a action template

reduce useless log
@z7658329
Copy link
Copy Markdown
Member

now we have some problems to solve: (TODO)

  1. we need adopt/update the config path for server(master) first (due to we support multi graph in 0.13, and the dir tree changed)
  2. we need update the client's APIVersion to meet the check (like CI in loader)
  3. last, after the server changed version to apache 1.0, we should also adapt it (later)

PS: could we use one commit ID to unify the CI? or use a action template

i can try to slove:
2. we need update the client's APIVersion to meet the check (like CI in loader)
3. last, after the server changed version to apache 1.0, we should also adapt it (later)

is it ok?

@imbajin
Copy link
Copy Markdown
Member Author

imbajin commented Oct 21, 2022

i can try to slove: 2. we need update the client's APIVersion to meet the check (like CI in loader) 3. last, after the server changed version to apache 1.0, we should also adapt it (later)

is it ok?

fine, but step3 need wait for server done, the 1,2 step are now blocking the merge process (The first one is not troublesome. You can try it 😃 )

wget "${HUGEGRAPH_LINK}" || exit 1
tar -zxvf hugegraph-${VERSION}.tar.gz
# TODO: lack incubator after apache package release (update it later)
tar zxvf hugegraph-${VERSION}.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can define an env var for it like PACKAGE_PREFIX="incubator-hugegraph"

Copy link
Copy Markdown
Member Author

@imbajin imbajin Oct 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@z7658329 you could also do it in the next PR (and the next comment below, the priority is low now)

Copy link
Copy Markdown
Member

@z7658329 z7658329 Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incubator-hugegraph
@imbajin @javeme
like this?
image

cd ../
rm -rf hugegraph
tar -zxvf hugegraph-*.tar.gz
tar zxvf hugegraph-*.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update "hugegraph-*" like the script in hugegraph server

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2022

Codecov Report

Merging #339 (e52fc43) into master (6d82b15) will decrease coverage by 28.51%.
The diff coverage is 71.42%.

@@              Coverage Diff              @@
##             master     #339       +/-   ##
=============================================
- Coverage     67.43%   38.92%   -28.52%     
- Complexity      878      966       +88     
=============================================
  Files            86      242      +156     
  Lines          4029     8111     +4082     
  Branches        477      719      +242     
=============================================
+ Hits           2717     3157      +440     
- Misses         1107     4775     +3668     
+ Partials        205      179       -26     
Impacted Files Coverage Δ
...java/com/baidu/hugegraph/structure/constant/T.java 0.00% <ø> (ø)
...java/com/baidu/hugegraph/structure/graph/Path.java 73.52% <0.00%> (ø)
...com/baidu/hugegraph/exception/ServerException.java 69.04% <50.00%> (ø)
.../java/com/baidu/hugegraph/driver/GraphManager.java 87.17% <100.00%> (ø)
.../com/baidu/hugegraph/loader/source/SourceType.java 0.00% <0.00%> (-100.00%) ⬇️
...m/baidu/hugegraph/loader/parser/CsvLineParser.java 0.00% <0.00%> (-100.00%) ⬇️
.../baidu/hugegraph/loader/reader/AbstractReader.java 0.00% <0.00%> (-100.00%) ⬇️
...baidu/hugegraph/loader/source/file/FileFormat.java 0.00% <0.00%> (-100.00%) ⬇️
...aidu/hugegraph/loader/executor/GroovyExecutor.java 0.00% <0.00%> (-100.00%) ⬇️
...aidu/hugegraph/loader/source/file/Compression.java 0.00% <0.00%> (-100.00%) ⬇️
... and 227 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin
Copy link
Copy Markdown
Member Author

imbajin commented Oct 30, 2022

@simon824 seems the hubble CI failed due to some reason, could u take a look with it?

image

If it's hard to fix quickly, we could merge this PR firstly to avoid suspend other PRs

@simon824
Copy link
Copy Markdown
Member

@imbajin It seems that the npm source address cannot be found, it may happen by accident, have you tried rerunning ci?

@imbajin
Copy link
Copy Markdown
Member Author

imbajin commented Oct 31, 2022

@imbajin It seems that the npm source address cannot be found, it may happen by accident, have you tried rerunning ci?

sure,try rerun it 3 times,and the other PR didnt have this problem?(cache? skip the real build?)

@z7658329
Copy link
Copy Markdown
Member

@imbajin @simon824
it seems works, see #351
the reason i think is maven-antrun-plugin cant resolve project.parent.basedir
4acc403944d23e44a38d71d53c365e7

* fix parent artifactId env

* fix parent artifactId env v2
@imbajin imbajin requested review from coderzc, javeme and zyxxoo October 31, 2022 07:49
@imbajin
Copy link
Copy Markdown
Member Author

imbajin commented Oct 31, 2022

After all ci pass,merge it first,then handle the ignore test in separate PR (like apache/hugegraph-commons#113)

@zyxxoo zyxxoo merged commit 067d488 into master Nov 1, 2022
@zyxxoo zyxxoo deleted the fix-ci branch November 1, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants