Skip to content

chore: update spark&flink scope to provided#363

Merged
imbajin merged 3 commits intoapache:masterfrom
simon824:rmsparkflinkdep
Nov 10, 2022
Merged

chore: update spark&flink scope to provided#363
imbajin merged 3 commits intoapache:masterfrom
simon824:rmsparkflinkdep

Conversation

@simon824
Copy link
Copy Markdown
Member

spark&flink loader needs to depend on the local spark&flink environment, so it's not necessary to introduce these dependencies in toolchains.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2022

Codecov Report

Merging #363 (70b0e3c) into master (a622f98) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #363   +/-   ##
=========================================
  Coverage     62.44%   62.44%           
  Complexity     1864     1864           
=========================================
  Files           260      260           
  Lines          9462     9462           
  Branches        874      874           
=========================================
  Hits           5909     5909           
  Misses         3169     3169           
  Partials        384      384           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

imbajin
imbajin previously approved these changes Nov 10, 2022
@imbajin
Copy link
Copy Markdown
Member

imbajin commented Nov 10, 2022

find another problem when test release, currently the package file is too big (seems we should config maven-assembly-plugin or dist module and pom)

image

refer:
https://github.com/apache/incubator-hugegraph-toolchain/blob/c893f50910732274477df98c95f570fce136f609/pom.xml#L220

maybe we could package the release in local env first (check and reduce the useless dependencies)

# Conflicts:
#	hugegraph-dist/scripts/dependency/known-dependencies.txt
@imbajin imbajin merged commit 4432b5d into apache:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants