Skip to content

adapt to org.apache package#364

Merged
imbajin merged 4 commits intoapache:client-renamefrom
z7658329:toolchain_rename
Nov 10, 2022
Merged

adapt to org.apache package#364
imbajin merged 4 commits intoapache:client-renamefrom
z7658329:toolchain_rename

Conversation

@z7658329
Copy link
Copy Markdown
Member

No description provided.

@z7658329
Copy link
Copy Markdown
Member Author

seems config COMMITID fall behind server's latest commitid

@imbajin
Copy link
Copy Markdown
Member

imbajin commented Nov 10, 2022

seems config COMMITID fall behind server's latest commitid

could update it, however how could we know it's the root cause? Seems other PR use the same commit but passed

we should better print the server.log error when it failed to start

@z7658329
Copy link
Copy Markdown
Member Author

z7658329 commented Nov 10, 2022

seems config COMMITID fall behind server's latest commitid

could update it, however how could we know it's the root cause? Seems other PR use the same commit but passed

we should better print the server.log error when it failed to start

yes ,we can test in local and fix this problem
image

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (client-rename@4c966ab). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             client-rename     #364   +/-   ##
================================================
  Coverage                 ?   53.94%           
  Complexity               ?      972           
================================================
  Files                    ?      172           
  Lines                    ?     5873           
  Branches                 ?      362           
================================================
  Hits                     ?     3168           
  Misses                   ?     2526           
  Partials                 ?      179           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@z7658329
Copy link
Copy Markdown
Member Author

looks strange, when start HugeGraphServer with https protocol,the loader ci failed while the tools ci success:

loader-ci:
https://github.com/apache/incubator-hugegraph-toolchain/actions/runs/3434429029/jobs/5725726685

tools-ci:
https://github.com/apache/incubator-hugegraph-toolchain/actions/runs/3434429034/jobs/5725726848

image

@imbajin
Copy link
Copy Markdown
Member

imbajin commented Nov 10, 2022

looks strange, when start HugeGraphServer with https protocol,the loader ci failed while the tools ci success:

loader ci fixed in #358, just ignore it now

@z7658329
Copy link
Copy Markdown
Member Author

looks strange, when start HugeGraphServer with https protocol,the loader ci failed while the tools ci success:

loader ci fixed in #358, just ignore it now

get it, should i copy the pom.xml to this branch?

@imbajin imbajin merged commit 964ac5b into apache:client-rename Nov 10, 2022
@z7658329
Copy link
Copy Markdown
Member Author

i have try to start hugegraph server with https protocal in local ,success, seems no matter with pr #358
image

imbajin pushed a commit that referenced this pull request Nov 10, 2022
* adapt to org.apache package

* use latest server commitid
imbajin pushed a commit that referenced this pull request Nov 14, 2022
* adapt to org.apache package

* use latest server commitid
imbajin pushed a commit to imbaGeek/hugegraph-toolchain that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

rename the toolchain package name to apache (until PR merged)

2 participants