Skip to content

fix loader-ci error#367

Merged
imbajin merged 5 commits intoapache:client-renamefrom
z7658329:feat/loader_ci_fail
Nov 10, 2022
Merged

fix loader-ci error#367
imbajin merged 5 commits intoapache:client-renamefrom
z7658329:feat/loader_ci_fail

Conversation

@z7658329
Copy link
Copy Markdown
Member

No description provided.

@z7658329 z7658329 changed the title cat start log fix loader-ci error Nov 10, 2022
@z7658329
Copy link
Copy Markdown
Member Author

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2022

Codecov Report

Merging #367 (7178e72) into client-rename (0e031ce) will increase coverage by 8.36%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             client-rename     #367      +/-   ##
===================================================
+ Coverage            53.94%   62.30%   +8.36%     
+ Complexity             972      892      -80     
===================================================
  Files                  172       91      -81     
  Lines                 5873     4399    -1474     
  Branches               362      515     +153     
===================================================
- Hits                  3168     2741     -427     
+ Misses                2526     1453    -1073     
- Partials               179      205      +26     
Impacted Files Coverage Δ
...ain/java/org/apache/hugegraph/util/CommonUtil.java
...org/apache/hugegraph/structure/graph/Vertices.java
.../hugegraph/serializer/direct/util/IdGenerator.java
.../java/org/apache/hugegraph/api/auth/BelongAPI.java
...va/org/apache/hugegraph/driver/VersionManager.java
...ava/org/apache/hugegraph/structure/graph/Path.java
...egraph/api/traverser/MultiNodeShortestPathAPI.java
...hugegraph/api/traverser/FusiformSimilarityAPI.java
...main/java/org/apache/hugegraph/util/TaskCache.java
...ph/structure/traverser/CustomizedPathsRequest.java
... and 253 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@z7658329
Copy link
Copy Markdown
Member Author

z7658329 commented Nov 10, 2022

image

see: https://github.com/apache/incubator-hugegraph-toolchain/actions/runs/3436527407/jobs/5730143794

it is strange, why client-ci,tools-ci success? @imbajin

because in client or tools module,there has rest-hugegraph.properties, and the default rpc.server_port is 8090, but in server project, the default rpc.server_port is 8091(i think the committer in order to avoid port conflict, so copy the server's config and change the port from 8091 to 8090.
so first time start hugegraph server with http protocal, will use rpc.server_port=8090 while start hugegraph server with https protocal will use rpc.server_port=8091 (see install_hugegraph_from_source.sh).

but in loader module, there is no rest-hugegraph.propertis config file,so first time start server with http protocal will use 8091 port while start server with https protocal still use 8091, so failed;

the most strange is that, from the above analysis,the load ci will always failed; i still cant understand why loader ci success before?

@imbajin
Copy link
Copy Markdown
Member

imbajin commented Nov 10, 2022

the most strange is that, from the above analysis,the load ci will always failed; i still cant understand why loader ci success before?

leave a question

@imbajin imbajin merged commit fda9096 into apache:client-rename Nov 10, 2022
imbajin pushed a commit that referenced this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants