Skip to content

refact: clean extra store file in all modules#434

Merged
javeme merged 8 commits intomasterfrom
fix-binary
Mar 25, 2023
Merged

refact: clean extra store file in all modules#434
javeme merged 8 commits intomasterfrom
fix-binary

Conversation

@imbajin
Copy link
Copy Markdown
Member

@imbajin imbajin commented Mar 1, 2023

TODO:

  • we need use a better way to download it when building binary package
  • ensure the deleted file keystore or license.json is no longer needed @javeme

@simon824 download the file in building or let user download it manually when they need https? (and we add a doc/link for it)

TODO: we need use a better way to download it when building binary package
@imbajin imbajin added dependencies Pull requests that update a dependency file ci Continuous integration labels Mar 1, 2023
@imbajin imbajin requested a review from javeme March 1, 2023 12:44
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2023

Codecov Report

Merging #434 (87c95a2) into master (6ac5a87) will increase coverage by 0.01%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##             master     #434      +/-   ##
============================================
+ Coverage     62.55%   62.57%   +0.01%     
- Complexity     1866     1867       +1     
============================================
  Files           260      260              
  Lines          9412     9418       +6     
  Branches        872      872              
============================================
+ Hits           5888     5893       +5     
- Misses         3142     3143       +1     
  Partials        382      382              
Impacted Files Coverage Δ
...rg/apache/hugegraph/loader/constant/Constants.java 75.00% <ø> (ø)
...apache/hugegraph/loader/util/HugeClientHolder.java 28.84% <0.00%> (+0.54%) ⬆️
...ain/java/org/apache/hugegraph/util/CommonUtil.java 86.95% <71.42%> (-6.80%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin changed the title chore: clean store file in all modules refact: clean extra store file in all modules Mar 16, 2023
@imbajin imbajin requested review from simon824 and z7658329 March 16, 2023 07:51
javeme
javeme previously approved these changes Mar 17, 2023
@imbajin
Copy link
Copy Markdown
Member Author

imbajin commented Mar 17, 2023

Download one file failed, need check it

image

Update: fixed it

@imbajin imbajin requested a review from javeme March 24, 2023 11:28
@javeme javeme merged commit 36a1ada into master Mar 25, 2023
@javeme javeme deleted the fix-binary branch March 25, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants