-
Notifications
You must be signed in to change notification settings - Fork 112
fix: Spark with loader has dependency conflicts #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0a87143
cf86be5
2550ab8
41e14d9
6f57a3d
7eca671
1e7cdc8
674e944
6ebd8a5
934cb96
2eb26c7
c06aa61
ff99f1e
b12af0a
0d7e26e
60691de
6993d9a
bc2c8e9
de42751
7a3a0a1
eac9b18
48faf3c
d782b57
074b6ab
4e8b7ff
d51053a
a415bab
ddb5e0b
8f3b528
88963c1
d8b31fc
053d27b
f817163
e610fb7
b0918d5
5658a87
841e774
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,7 @@ | |
| import org.slf4j.Logger; | ||
|
|
||
| import java.io.Serializable; | ||
| import java.util.Optional; | ||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.Iterator; | ||
|
|
@@ -292,9 +293,13 @@ private void parse(Row row, Map.Entry<ElementBuilder, List<GraphElement>> builde | |
| case FILE: | ||
| case HDFS: | ||
| FileSource fileSource = struct.input().asFileSource(); | ||
| String delimiter = fileSource.delimiter(); | ||
| elements = builder.build(fileSource.header(), | ||
| row.mkString(delimiter).split(delimiter)); | ||
| String delimiter = fileSource.delimiter() ; | ||
| if (Optional.ofNullable(delimiter).isPresent()) { | ||
| elements = builder.build(fileSource.header(), | ||
| row.mkString(delimiter).split(delimiter)); | ||
|
Comment on lines
+297
to
+299
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @liuxiaocs7 could test it again? |
||
| }else { | ||
| elements = builder.build(row); | ||
| } | ||
| break; | ||
| case JDBC: | ||
| Object[] structFields = JavaConverters.asJavaCollection(row.schema().toList()) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| shaded.org.glassfish.jersey.client.JerseyClientBuilder | ||
|
Comment on lines
+12
to
+16
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have a question, why do I need to add SPI to these two classes (this one and below), it seems to be able to import normally without adding these two?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hello, I understand that it is because SPI added these two classes in jersey-client jar and other jars. When we do shade, we are actually changing the path information of these two classes, so we need to add SPI to these two shade classes. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| org.jvnet.hk2.external.generator.ServiceLocatorGeneratorImpl |
Uh oh!
There was an error while loading. Please reload this page.