Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
0a87143
Merge pull request #1 from apache/master
haohao0103 Sep 16, 2022
cf86be5
Merge branch 'apache:master' into master
haohao0103 Oct 21, 2022
2550ab8
Merge branch 'apache:master' into master
haohao0103 Oct 27, 2022
41e14d9
Merge branch 'apache:master' into master
haohao0103 Nov 2, 2022
6f57a3d
Merge branch 'apache:master' into master
haohao0103 Nov 4, 2022
7eca671
Merge branch 'apache:master' into master
haohao0103 Nov 7, 2022
1e7cdc8
Merge branch 'apache:master' into master
haohao0103 Nov 9, 2022
674e944
Merge branch 'apache:master' into master
haohao0103 Jan 3, 2023
6ebd8a5
Merge branch 'apache:master' into master
haohao0103 Feb 8, 2023
934cb96
Merge branch 'apache:master' into master
haohao0103 Feb 20, 2023
2eb26c7
Merge branch 'apache:master' into master
haohao0103 Apr 7, 2023
c06aa61
Merge branch 'apache:master' into master
haohao0103 May 17, 2023
ff99f1e
fix:#404
May 19, 2023
b12af0a
fix:#404
May 19, 2023
0d7e26e
Merge branch 'master' into schemaCache-optimize
simon824 May 22, 2023
60691de
Merge branch 'apache:master' into master
haohao0103 Jun 14, 2023
6993d9a
Merge branch 'apache:master' into schemaCache-optimize
haohao0103 Jun 14, 2023
bc2c8e9
fix:#464
Jun 14, 2023
de42751
fix:#464
Jun 14, 2023
7a3a0a1
fix:#464
Jun 14, 2023
eac9b18
fix:#464
Jun 14, 2023
48faf3c
fix:#464
Jun 14, 2023
d782b57
fix:#464
Jun 15, 2023
074b6ab
fix:#464
Jun 15, 2023
4e8b7ff
fix:#464
Jun 15, 2023
d51053a
fix:#464
Jun 15, 2023
a415bab
Merge branch 'apache:master' into master
haohao0103 Jun 19, 2023
ddb5e0b
Merge remote-tracking branch 'origin/master' into schemaCache-optimize
Jun 19, 2023
8f3b528
fix:#464
Jun 19, 2023
88963c1
fix:#464
Jun 19, 2023
d8b31fc
fix:#488
Jul 10, 2023
053d27b
fix:#488
Jul 11, 2023
f817163
fix:#488
Jul 12, 2023
e610fb7
Revert "fix:#488 bypass server for hbase bulk delete massive vertices…
Aug 2, 2023
b0918d5
Revert "fix:#488 bypass server for hbase bulk delete massive vertices…
Aug 2, 2023
5658a87
fix:#464
Aug 2, 2023
841e774
fix:#464
Aug 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hugegraph-loader/assembly/descriptor/assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
<fileSet>
<directory>${project.build.directory}</directory>
<outputDirectory>lib</outputDirectory>
<excludes>
<exclude>hugegraph-loader-1.0.0.jar</exclude>
</excludes>
<includes>
<include>*.jar</include>
</includes>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ get_params "$@"
echo "engine_params: $ENGINE_PARAMS"
echo "hugegraph_params: $HUGEGRAPH_PARAMS"

ASSEMBLY_JAR_NAME=$(find "${LIB_DIR}" -name 'hugegraph-loader*.jar')
ASSEMBLY_JAR_NAME=$(find "${LIB_DIR}" -name 'apache-hugegraph-loader*.jar')

DEFAULT_APP_NAME="hugegraph-spark-loader"
APP_NAME=${APP_NAME:-$DEFAULT_APP_NAME}
Expand Down
60 changes: 60 additions & 0 deletions hugegraph-loader/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,17 @@
<artifactId>jersey-server</artifactId>
<groupId>org.glassfish.jersey.core</groupId>
</exclusion>
<exclusion>
<artifactId>gson</artifactId>
<groupId>com.google.code.gson</groupId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<artifactId>gson</artifactId>
<groupId>com.google.code.gson</groupId>
<version>${gson.version}</version>
</dependency>
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-sql_${scala.version}</artifactId>
Expand Down Expand Up @@ -614,6 +623,57 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.4.1</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<createDependencyReducedPom>false</createDependencyReducedPom>
<finalName>${final.name}-shaded</finalName>
<relocations>
<relocation>
<pattern>org.glassfish.jersey</pattern>
<shadedPattern>shaded.org.glassfish.jersey</shadedPattern>
</relocation>
<relocation>
<pattern>jakarta.ws.rs</pattern>
<shadedPattern>shaded.jakarta.ws.rs</shadedPattern>
</relocation>
<relocation>
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
<relocation>
<pattern>org.glassfish.hk2</pattern>
<shadedPattern>shaded.org.glassfish.hk2</shadedPattern>
</relocation>
<relocation>
<pattern>org.jvnet.hk2</pattern>
<shadedPattern>shaded.org.jvnet.hk2</shadedPattern>
</relocation>
</relocations>
<transformers>
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer">
</transformer>
</transformers>
<filters>
<filter>
<artifact>*:*</artifact>
<excludes>
<exclude>module-info.class</exclude>
</excludes>
</filter>
</filters>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
import org.slf4j.Logger;

import java.io.Serializable;
import java.util.Optional;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
Expand Down Expand Up @@ -292,9 +293,13 @@ private void parse(Row row, Map.Entry<ElementBuilder, List<GraphElement>> builde
case FILE:
case HDFS:
FileSource fileSource = struct.input().asFileSource();
String delimiter = fileSource.delimiter();
elements = builder.build(fileSource.header(),
row.mkString(delimiter).split(delimiter));
String delimiter = fileSource.delimiter() ;
if (Optional.ofNullable(delimiter).isPresent()) {
elements = builder.build(fileSource.header(),
row.mkString(delimiter).split(delimiter));
Comment on lines +297 to +299
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuxiaocs7 could test it again?

}else {
elements = builder.build(row);
}
break;
case JDBC:
Object[] structFields = JavaConverters.asJavaCollection(row.schema().toList())
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
shaded.org.glassfish.jersey.client.JerseyClientBuilder
Comment on lines +12 to +16
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, why do I need to add SPI to these two classes (this one and below), it seems to be able to import normally without adding these two?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, I understand that it is because SPI added these two classes in jersey-client jar and other jars. When we do shade, we are actually changing the path information of these two classes, so we need to add SPI to these two shade classes.

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
org.jvnet.hk2.external.generator.ServiceLocatorGeneratorImpl