Implement a ThreadLocalCache to improve read perf#1155
Closed
Implement a ThreadLocalCache to improve read perf#1155
Conversation
javeme
requested changes
Aug 26, 2020
|
|
||
| @Override | ||
| protected boolean write(K id, V value) { | ||
| this.getOrNewCache(); |
Contributor
There was a problem hiding this comment.
check capacity and throw if ooc
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
=============================================
+ Coverage 29.65% 65.56% +35.90%
- Complexity 263 5654 +5391
=============================================
Files 75 358 +283
Lines 4208 28967 +24759
Branches 510 4059 +3549
=============================================
+ Hits 1248 18992 +17744
- Misses 2797 8089 +5292
- Partials 163 1886 +1723
Continue to review full report at Codecov.
|
Change-Id: I372fb5a56f374fc3993d8bdcbbb0ef07b5f160c7
Change-Id: Id3a39da5cc683fc90f07ad5b8eaae9db5eb9244d
1c96838 to
88aaaba
Compare
Contributor
Author
|
After the loader performance test, there is no obvious performance improvement for the two caches, so close this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I372fb5a56f374fc3993d8bdcbbb0ef07b5f160c7