fix psotgresql init failed due to not exist same name db with user#1293
Merged
fix psotgresql init failed due to not exist same name db with user#1293
Conversation
Change-Id: I955fb0a474904470355b92dbc9bf3aa08ea4f61e fixed: #1285
Codecov Report
@@ Coverage Diff @@
## master #1293 +/- ##
============================================
+ Coverage 62.09% 62.10% +0.01%
- Complexity 5767 5773 +6
============================================
Files 377 377
Lines 31493 31498 +5
Branches 4413 4413
============================================
+ Hits 19556 19563 +7
Misses 9946 9946
+ Partials 1991 1989 -2
Continue to review full report at Codecov.
|
javeme
requested changes
Dec 10, 2020
| #jdbc.url=jdbc:postgresql://localhost:5432/ | ||
| #jdbc.username=postgres | ||
| #jdbc.password= | ||
| #postgresql.connect_database=template1 |
Contributor
There was a problem hiding this comment.
prefer jdbc.connect_database
| @Override | ||
| protected String connectDatabase() { | ||
| return this.config().get(PostgresqlOptions.POSTGRESQL_CONNECT_DATABASE); | ||
| } |
javeme
approved these changes
Dec 10, 2020
Linary
approved these changes
Dec 14, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I955fb0a474904470355b92dbc9bf3aa08ea4f61e
fixed: #1285