Skip to content

Fix add schema from follower then list all without it #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Linary merged 3 commits into from
Jan 14, 2021
Merged

Fix add schema from follower then list all without it #1325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59703fd
Fix add schema from follower then list all without it
Linary Jan 7, 2021
8d127a2
tiny improve
Linary Jan 7, 2021
ba72d44
tiny improve
Linary Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/CachedSchemaTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ private void listenChanges() {
schema.name());
this.nameCache.invalidate(prefixedName);
}
this.resetCachedAll(type);
return true;
} else if (ACTION_CLEAR.equals(args[0])) {
this.clearCache();
Expand All @@ -137,6 +138,11 @@ private void listenChanges() {
}
}

private final void resetCachedAll(HugeType type) {
// Set the cache all flag of the schema type to false
this.cachedTypes().put(type, false);
}

private void clearCache() {
this.idCache.clear();
this.nameCache.clear();
Expand Down
8 changes: 7 additions & 1 deletion hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/StoreStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ private void applyCommand(StoreType type, StoreAction action,

@Override
public void onSnapshotSave(SnapshotWriter writer, Closure done) {
LOG.debug("The node {} start snapshot save", this.node().nodeId());
LOG.info("The node {} start snapshot saving", this.node().nodeId());
this.snapshotFile.save(writer, done, this.context.snapshotExecutor());
}

Expand All @@ -206,6 +206,12 @@ public boolean onSnapshotLoad(SnapshotReader reader) {
LOG.warn("Leader is not supposed to load snapshot.");
return false;
}
/*
* Snapshot load occured in RaftNode constructor, specifically at step
* `this.node = this.initRaftNode()`, at this time the NodeImpl is null
* in RaftNode so we can't call `this.node().nodeId()`
*/
LOG.info("The node {} start snapshot loading", this.context.endpoint());
return this.snapshotFile.load(reader);
}

Expand Down
6 changes: 3 additions & 3 deletions ...graph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ public static synchronized RocksDBOptions instance() {
"rocksdb.data_disks",
false,
"The optimized disks for storing data of RocksDB. " +
"The format of each element: `STORE/TABLE: /path/to/disk`." +
"Allowed keys are [graph/vertex, graph/edge_out, graph/edge_in, " +
"graph/secondary_index, graph/range_index]",
"The format of each element: `STORE/TABLE: /path/disk`." +
"Allowed keys are [g/vertex, g/edge_out, g/edge_in, " +
"g/secondary_index, g/range_index]",
null,
String.class,
ImmutableList.of()
Expand Down