Skip to content

fix ttl not work due to job not close tx#1330

Merged
Linary merged 2 commits intomasterfrom
fix-gremlin-job-ttl
Jan 13, 2021
Merged

fix ttl not work due to job not close tx#1330
Linary merged 2 commits intomasterfrom
fix-gremlin-job-ttl

Conversation

@zhoney
Copy link
Copy Markdown
Contributor

@zhoney zhoney commented Jan 12, 2021

Change-Id: Ic4a3bc11e67f92c88772149d5c304a2c1da0ec64

Change-Id: Ic4a3bc11e67f92c88772149d5c304a2c1da0ec64
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1330 (4047231) into master (26ac664) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1330      +/-   ##
============================================
+ Coverage     61.88%   62.32%   +0.43%     
- Complexity     5751     5770      +19     
============================================
  Files           377      377              
  Lines         31543    31553      +10     
  Branches       4419     4422       +3     
============================================
+ Hits          19521    19666     +145     
+ Misses        10029     9887     -142     
- Partials       1993     2000       +7     
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/baidu/hugegraph/job/SysJob.java 75.00% <100.00%> (+3.57%) 3.00 <1.00> (ø)
...src/main/java/com/baidu/hugegraph/job/UserJob.java 100.00% <100.00%> (ø) 4.00 <1.00> (ø)
...in/java/com/baidu/hugegraph/task/TaskCallable.java 60.65% <100.00%> (+3.51%) 13.00 <3.00> (+2.00)
...n/java/com/baidu/hugegraph/schema/PropertyKey.java 77.09% <0.00%> (-0.60%) 51.00% <0.00%> (ø%)
...in/java/com/baidu/hugegraph/StandardHugeGraph.java 78.98% <0.00%> (-0.39%) 119.00% <0.00%> (+1.00%) ⬇️
...aidu/hugegraph/schema/builder/AbstractBuilder.java 89.28% <0.00%> (-0.37%) 13.00% <0.00%> (-1.00%)
...aidu/hugegraph/backend/tx/AbstractTransaction.java 72.90% <0.00%> (-0.35%) 51.00% <0.00%> (-2.00%)
...om/baidu/hugegraph/task/StandardTaskScheduler.java 77.44% <0.00%> (-0.23%) 85.00% <0.00%> (-2.00%)
.../baidu/hugegraph/backend/tx/SchemaTransaction.java 91.50% <0.00%> (-0.05%) 70.00% <0.00%> (ø%)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 65.30% <0.00%> (ø) 9.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ac664...4047231. Read the comment docs.

}

protected void closeTx() {
if (this.graph().tx().isOpen()) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define tx first

Change-Id: I0f473063f6df1e43170f01a655a87a1c790f028a
@Linary Linary merged commit e0f36bd into master Jan 13, 2021
@Linary Linary deleted the fix-gremlin-job-ttl branch January 13, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants