Skip to content

refactor UserManager to AuthManager#1363

Merged
Linary merged 4 commits intomasterfrom
refactor-user_manager-to-auth_manager
Mar 3, 2021
Merged

refactor UserManager to AuthManager#1363
Linary merged 4 commits intomasterfrom
refactor-user_manager-to-auth_manager

Conversation

@javeme
Copy link
Copy Markdown
Contributor

@javeme javeme commented Feb 20, 2021

Change-Id: Icd421eac05da2cfeb629974d282f9a6cd9c523f5

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2021

Codecov Report

Merging #1363 (06d3720) into master (964daf1) will increase coverage by 0.01%.
The diff coverage is 4.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1363      +/-   ##
============================================
+ Coverage     62.38%   62.39%   +0.01%     
+ Complexity     5827     5817      -10     
============================================
  Files           385      385              
  Lines         31940    31922      -18     
  Branches       4458     4451       -7     
============================================
- Hits          19925    19917       -8     
+ Misses         9995     9984      -11     
- Partials       2020     2021       +1     
Impacted Files Coverage Δ Complexity Δ
...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/com/baidu/hugegraph/api/auth/BelongAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/com/baidu/hugegraph/api/auth/GroupAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/com/baidu/hugegraph/api/auth/TargetAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/com/baidu/hugegraph/api/auth/UserAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../com/baidu/hugegraph/auth/ConfigAuthenticator.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/com/baidu/hugegraph/auth/HugeAuthenticator.java 20.32% <ø> (ø) 0.00 <0.00> (ø)
...com/baidu/hugegraph/auth/HugeFactoryAuthProxy.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 3.98% <0.00%> (ø) 0.00 <0.00> (ø)
...om/baidu/hugegraph/auth/StandardAuthenticator.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964daf1...bad38aa. Read the comment docs.

houzhizhen
houzhizhen previously approved these changes Feb 22, 2021
@javeme javeme force-pushed the refactor-user_manager-to-auth_manager branch 2 times, most recently from 6c22316 to ef7bfab Compare February 23, 2021 12:51
javeme added 4 commits March 3, 2021 17:01
Change-Id: Icd421eac05da2cfeb629974d282f9a6cd9c523f5
Change-Id: I186fa60529bd26a4c06eb5cfc17e5d6a453a3a52
Change-Id: I95c6b4a430ce9e1e698deacfa98af9bde9f2751e
Change-Id: Ic4d087115cb1d8a5898d3abc8fef5a23947ff18b
@javeme javeme force-pushed the refactor-user_manager-to-auth_manager branch from ef7bfab to bad38aa Compare March 3, 2021 09:44
@Linary Linary merged commit fb108f1 into master Mar 3, 2021
@Linary Linary deleted the refactor-user_manager-to-auth_manager branch March 3, 2021 11:44
@javeme
Copy link
Copy Markdown
Contributor Author

javeme commented Mar 3, 2021

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hugegraph-core: Compilation failure
[ERROR] /home/travis/build/hugegraph/hugegraph/hugegraph-core/src/main/java/com/baidu/hugegraph/auth/SchemaDefine.java:[245,39] cannot find symbol
[ERROR]   symbol:   class Namifiable
[ERROR]   location: class com.baidu.hugegraph.auth.SchemaDefine

this error will be fixed at #1376

javeme added a commit that referenced this pull request Mar 3, 2021
fix #1363

Change-Id: I7b7ee43dfd92e1c54dc191f0ecba9557e02fa45b
javeme added a commit that referenced this pull request Mar 4, 2021
fix #1363

Change-Id: I7b7ee43dfd92e1c54dc191f0ecba9557e02fa45b
Linary pushed a commit that referenced this pull request Mar 4, 2021
fix #1363

Change-Id: I7b7ee43dfd92e1c54dc191f0ecba9557e02fa45b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants