bump netty-all from 4.1.13.Final to 4.1.42.Final by javeme · Pull Request #1403 · apache/hugegraph

javeme · 2021-03-23T04:11:59Z

related: hugegraph@bd06f1a
related: hugegraph@accc27f

Change-Id: I1893ec67371712b091f35b085611959dd9d429cc

javeme · 2021-03-23T04:12:08Z

NOTE: hugegraph netty version now is 4.1.13.Final:

// org.apache.tinkerpop:gremlin-driver:jar:3.4.3:
io.netty:netty-all:jar:4.1.36.Final

// com.alipay.sofa:bolt:jar:1.6.2:
io.netty:netty-all:jar:4.1.42.Final

// com.datastax.cassandra:cassandra-driver-core:jar:3.6.0:
io.netty:netty-handler:jar:4.0.56.Final

// cassandra-driver:
io.netty:netty-all:jar:4.1.13.Final
io.netty:netty-transport-native-epoll:jar:4.1.13.Final

javeme · 2021-03-23T04:30:31Z

If we use 4.1.42.Final and keep netty-transport-native-epoll, gremlin-server can't start with error:

2021-03-23 12:28:07 2969  [main] [ERROR] com.baidu.hugegraph.dist.HugeGraphServer [] - HugeGremlinServer start error:
java.lang.ExceptionInInitializerError: null
        at java.lang.Class.forName0(Native Method) ~[?:1.8.0_111]
        at java.lang.Class.forName(Class.java:264) ~[?:1.8.0_111]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.initializeGremlinScriptEngineManager(GremlinExecutor.java:413) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.<init>(GremlinExecutor.java:108) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.<init>(GremlinExecutor.java:77) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor$Builder.create(GremlinExecutor.java:592) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.server.util.ServerGremlinExecutor.<init>(ServerGremlinExecutor.java:128) ~[gremlin-server-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.server.GremlinServer.<init>(GremlinServer.java:122) ~[gremlin-server-3.4.3.jar:3.4.3]
        at com.baidu.hugegraph.auth.ContextGremlinServer.<init>(ContextGremlinServer.java:46) ~[hugegraph-api-0.11.2.jar:0.59.0.0]
        at com.baidu.hugegraph.dist.HugeGremlinServer.startWithInjectTraversal(HugeGremlinServer.java:78) ~[hugegraph-dist-0.11.2.jar:?]
        at com.baidu.hugegraph.dist.HugeGremlinServer.start(HugeGremlinServer.java:61) ~[hugegraph-dist-0.11.2.jar:?]
        at com.baidu.hugegraph.dist.HugeGraphServer.<init>(HugeGraphServer.java:44) [hugegraph-dist-0.11.2.jar:?]
        at com.baidu.hugegraph.dist.HugeGraphServer.main(HugeGraphServer.java:100) [hugegraph-dist-0.11.2.jar:?]
Caused by: com.baidu.hugegraph.HugeException: Failed to scan classes under package com.baidu.hugegraph.type.define
        at com.baidu.hugegraph.plugin.HugeGraphGremlinPlugin.<clinit>(HugeGraphGremlinPlugin.java:51) ~[hugegraph-core-0.11.2.jar:0.11.2.0]
        ... 13 more
Caused by: java.util.zip.ZipException: invalid LOC header (bad signature)
        at java.util.zip.ZipFile.read(Native Method) ~[?:1.8.0_111]
        at java.util.zip.ZipFile.access$1400(ZipFile.java:60) ~[?:1.8.0_111]
        at java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:717) ~[?:1.8.0_111]
        at java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:419) ~[?:1.8.0_111]
        at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158) ~[?:1.8.0_111]
        at sun.misc.IOUtils.readFully(IOUtils.java:65) ~[?:1.8.0_111]
        at java.util.jar.JarFile.getBytes(JarFile.java:425) ~[?:1.8.0_111]
        at java.util.jar.JarFile.getManifestFromReference(JarFile.java:193) ~[?:1.8.0_111]
        at java.util.jar.JarFile.getManifest(JarFile.java:180) ~[?:1.8.0_111]
        at com.google.common.reflect.ClassPath$Scanner.scanJar(ClassPath.java:397) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath$Scanner.scanFrom(ClassPath.java:384) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath$Scanner.scan(ClassPath.java:361) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath$Scanner.scan(ClassPath.java:354) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath.from(ClassPath.java:119) ~[guava-25.1-jre.jar:?]
        at com.baidu.hugegraph.util.ReflectionUtil.classes(ReflectionUtil.java:90) ~[hugegraph-common-1.8.1.jar:1.8.1.0]
        at com.baidu.hugegraph.plugin.HugeGraphGremlinPlugin.<clinit>(HugeGraphGremlinPlugin.java:49) ~[hugegraph-core-0.11.2.jar:0.11.2.0]
        ... 13 more

netty jars in lib:

$ ls -lh hugegraph-0.11.2/lib/ |grep netty
-rw-r--r--  1 user  INTERNAL\Domain Users   6.8M  3 23 11:27 grpc-netty-shaded-1.28.0.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   3.8M  3 23 11:27 hbase-shaded-netty-2.1.0.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   3.9M  3 23 11:27 netty-all-4.1.42.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   318K  3 23 11:27 netty-buffer-4.1.42.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   610K  3 23 11:27 netty-common-4.1.42.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users    32K  3 23 11:27 netty-resolver-4.1.42.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   478K  3 23 11:27 netty-transport-4.1.42.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   189K  3 23 11:27 netty-transport-native-epoll-4.1.42.Final-linux-x86_64.jar
-rw-r--r--  1 user  INTERNAL\Domain Users    32K  3 23 11:27 netty-transport-native-unix-common-4.1.42.Final.jar

cassandra pom.xml:

        <dependency>
            <groupId>com.datastax.cassandra</groupId>
            <artifactId>cassandra-driver-core</artifactId>
            <version>3.6.0</version>
            <exclusions>
                <exclusion>
                    <groupId>io.netty</groupId>
                    <artifactId>netty-handler</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <!-- netty-all contain netty-transport-native-epoll, https://github.com/netty/netty/issues/8714 -->
            <groupId>io.netty</groupId>
            <artifactId>netty-all</artifactId>
            <version>4.1.42.Final</version>
        </dependency>
        <dependency>
            <groupId>io.netty</groupId>
            <artifactId>netty-transport-native-epoll</artifactId>
            <version>4.1.42.Final</version>
            <classifier>linux-x86_64</classifier>
        </dependency>

codecov · 2021-03-23T04:40:50Z

Codecov Report

Merging #1403 (d8d1348) into master (4c4b770) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1403      +/-   ##
============================================
- Coverage     62.05%   62.04%   -0.02%     
- Complexity     5837     5838       +1     
============================================
  Files           386      386              
  Lines         32185    32192       +7     
  Branches       4494     4497       +3     
============================================
+ Hits          19974    19975       +1     
- Misses        10178    10185       +7     
+ Partials       2033     2032       -1

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/baidu/hugegraph/api/auth/UserAPI.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...om/baidu/hugegraph/auth/StandardAuthenticator.java	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...idu/hugegraph/api/filter/AuthenticationFilter.java	`32.09% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...om/baidu/hugegraph/task/StandardTaskScheduler.java	`76.35% <0.00%> (+0.24%)`	`86.00% <0.00%> (+1.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4b770...d8d1348. Read the comment docs.

javeme · 2021-03-23T06:11:57Z

If we use 4.1.42.Final and not exclude netty-handler:

2021-03-23 14:09:28 3431  [main] [ERROR] com.baidu.hugegraph.dist.HugeGraphServer [] - HugeGremlinServer start error: 
java.lang.ExceptionInInitializerError: null
        at java.lang.Class.forName0(Native Method) ~[?:1.8.0_111]
        at java.lang.Class.forName(Class.java:264) ~[?:1.8.0_111]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.initializeGremlinScriptEngineManager(GremlinExecutor.java:413) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.<init>(GremlinExecutor.java:108) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.<init>(GremlinExecutor.java:77) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor$Builder.create(GremlinExecutor.java:592) ~[gremlin-groovy-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.server.util.ServerGremlinExecutor.<init>(ServerGremlinExecutor.java:128) ~[gremlin-server-3.4.3.jar:3.4.3]
        at org.apache.tinkerpop.gremlin.server.GremlinServer.<init>(GremlinServer.java:122) ~[gremlin-server-3.4.3.jar:3.4.3]
        at com.baidu.hugegraph.auth.ContextGremlinServer.<init>(ContextGremlinServer.java:46) ~[hugegraph-api-0.11.2.jar:0.59.0.0]
        at com.baidu.hugegraph.dist.HugeGremlinServer.startWithInjectTraversal(HugeGremlinServer.java:78) ~[hugegraph-dist-0.11.2.jar:?]
        at com.baidu.hugegraph.dist.HugeGremlinServer.start(HugeGremlinServer.java:61) ~[hugegraph-dist-0.11.2.jar:?]
        at com.baidu.hugegraph.dist.HugeGraphServer.<init>(HugeGraphServer.java:44) [hugegraph-dist-0.11.2.jar:?]
        at com.baidu.hugegraph.dist.HugeGraphServer.main(HugeGraphServer.java:100) [hugegraph-dist-0.11.2.jar:?]
Caused by: com.baidu.hugegraph.HugeException: Failed to scan classes under package com.baidu.hugegraph.type.define
        at com.baidu.hugegraph.plugin.HugeGraphGremlinPlugin.<clinit>(HugeGraphGremlinPlugin.java:51) ~[hugegraph-core-0.11.2.jar:0.11.2.0]
        ... 13 more
Caused by: java.util.zip.ZipException: invalid LOC header (bad signature)
        at java.util.zip.ZipFile.read(Native Method) ~[?:1.8.0_111]
        at java.util.zip.ZipFile.access$1400(ZipFile.java:60) ~[?:1.8.0_111]
        at java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:717) ~[?:1.8.0_111]
        at java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:419) ~[?:1.8.0_111]
        at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158) ~[?:1.8.0_111]
        at sun.misc.IOUtils.readFully(IOUtils.java:65) ~[?:1.8.0_111]
        at java.util.jar.JarFile.getBytes(JarFile.java:425) ~[?:1.8.0_111]
        at java.util.jar.JarFile.getManifestFromReference(JarFile.java:193) ~[?:1.8.0_111]
        at java.util.jar.JarFile.getManifest(JarFile.java:180) ~[?:1.8.0_111]
        at com.google.common.reflect.ClassPath$Scanner.scanJar(ClassPath.java:397) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath$Scanner.scanFrom(ClassPath.java:384) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath$Scanner.scan(ClassPath.java:361) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath$Scanner.scan(ClassPath.java:354) ~[guava-25.1-jre.jar:?]
        at com.google.common.reflect.ClassPath.from(ClassPath.java:119) ~[guava-25.1-jre.jar:?]
        at com.baidu.hugegraph.util.ReflectionUtil.classes(ReflectionUtil.java:90) ~[hugegraph-common-1.8.1.jar:1.8.1.0]
        at com.baidu.hugegraph.plugin.HugeGraphGremlinPlugin.<clinit>(HugeGraphGremlinPlugin.java:49) ~[hugegraph-core-0.11.2.jar:0.11.2.0]
        ... 13 more
Exception in thread "main" java.lang.ExceptionInInitializerError
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:264)
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.initializeGremlinScriptEngineManager(GremlinExecutor.java:413)
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.<init>(GremlinExecutor.java:108)
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.<init>(GremlinExecutor.java:77)
        at org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor$Builder.create(GremlinExecutor.java:592)
        at org.apache.tinkerpop.gremlin.server.util.ServerGremlinExecutor.<init>(ServerGremlinExecutor.java:128)
        at org.apache.tinkerpop.gremlin.server.GremlinServer.<init>(GremlinServer.java:122)
        at com.baidu.hugegraph.auth.ContextGremlinServer.<init>(ContextGremlinServer.java:46)
        at com.baidu.hugegraph.dist.HugeGremlinServer.startWithInjectTraversal(HugeGremlinServer.java:78)
        at com.baidu.hugegraph.dist.HugeGremlinServer.start(HugeGremlinServer.java:61)
        at com.baidu.hugegraph.dist.HugeGraphServer.<init>(HugeGraphServer.java:44)
        at com.baidu.hugegraph.dist.HugeGraphServer.main(HugeGraphServer.java:100)
Caused by: com.baidu.hugegraph.HugeException: Failed to scan classes under package com.baidu.hugegraph.type.define
        at com.baidu.hugegraph.plugin.HugeGraphGremlinPlugin.<clinit>(HugeGraphGremlinPlugin.java:51)
        ... 13 more
Caused by: java.util.zip.ZipException: invalid LOC header (bad signature)
        at java.util.zip.ZipFile.read(Native Method)
        at java.util.zip.ZipFile.access$1400(ZipFile.java:60)
        at java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:717)
        at java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:419)
        at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)
        at sun.misc.IOUtils.readFully(IOUtils.java:65)
        at java.util.jar.JarFile.getBytes(JarFile.java:425)
        at java.util.jar.JarFile.getManifestFromReference(JarFile.java:193)
        at java.util.jar.JarFile.getManifest(JarFile.java:180)
        at com.google.common.reflect.ClassPath$Scanner.scanJar(ClassPath.java:397)
        at com.google.common.reflect.ClassPath$Scanner.scanFrom(ClassPath.java:384)
        at com.google.common.reflect.ClassPath$Scanner.scan(ClassPath.java:361)
        at com.google.common.reflect.ClassPath$Scanner.scan(ClassPath.java:354)
        at com.google.common.reflect.ClassPath.from(ClassPath.java:119)
        at com.baidu.hugegraph.util.ReflectionUtil.classes(ReflectionUtil.java:90)
        at com.baidu.hugegraph.plugin.HugeGraphGremlinPlugin.<clinit>(HugeGraphGremlinPlugin.java:49)
        ... 13 more

netty jars in lib:

$ ls -lh hugegraph-0.11.2/lib/ |grep netty
-rw-r--r--  1 user  INTERNAL\Domain Users   6.8M  3 23 14:02 grpc-netty-shaded-1.28.0.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   3.8M  3 23 14:02 hbase-shaded-netty-2.1.0.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   3.9M  3 23 14:02 netty-all-4.1.42.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   229K  3 23 14:02 netty-buffer-4.0.56.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   150K  3 23 14:02 netty-codec-4.0.56.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   423K  3 23 14:02 netty-common-4.0.56.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   351K  3 23 14:02 netty-handler-4.0.56.Final.jar
-rw-r--r--  1 user  INTERNAL\Domain Users   413K  3 23 14:02 netty-transport-4.0.56.Final.jar

cassandra pom.xml:

        <dependency>
            <groupId>com.datastax.cassandra</groupId>
            <artifactId>cassandra-driver-core</artifactId>
            <version>3.6.0</version>
        </dependency>
        <dependency>
            <!-- netty-all contain netty-transport-native-epoll, https://github.com/netty/netty/issues/8714 -->
            <groupId>io.netty</groupId>
            <artifactId>netty-all</artifactId>
            <version>4.1.42.Final</version>
        </dependency>

bump netty-all from 4.1.13.Final to 4.1.42.Final

d8d1348

Change-Id: I1893ec67371712b091f35b085611959dd9d429cc

Linary approved these changes Mar 26, 2021

View reviewed changes

zhoney approved these changes Mar 26, 2021

View reviewed changes

zhoney merged commit f57ad0d into master Mar 26, 2021

zhoney deleted the netty-version-4.1.42 branch March 26, 2021 10:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump netty-all from 4.1.13.Final to 4.1.42.Final#1403

bump netty-all from 4.1.13.Final to 4.1.42.Final#1403
zhoney merged 1 commit intomasterfrom
netty-version-4.1.42

javeme commented Mar 23, 2021 •

edited

Loading

Uh oh!

javeme commented Mar 23, 2021

Uh oh!

javeme commented Mar 23, 2021 •

edited

Loading

Uh oh!

codecov bot commented Mar 23, 2021 •

edited

Loading

Uh oh!

javeme commented Mar 23, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

javeme commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javeme commented Mar 23, 2021

Uh oh!

javeme commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

javeme commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

javeme commented Mar 23, 2021 •

edited

Loading

javeme commented Mar 23, 2021 •

edited

Loading

codecov bot commented Mar 23, 2021 •

edited

Loading

javeme commented Mar 23, 2021 •

edited

Loading