Add system schema store by Linary · Pull Request #1533 · apache/hugegraph

Linary · 2021-07-01T14:09:31Z

Change-Id: I2feabace71f266d6be6c2094c30cd19f74ab7f7d

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/SystemSchemaStore.java

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/SchemaTransaction.java

codecov · 2021-07-06T07:07:34Z

Codecov Report

Merging #1533 (faf6b99) into master (153fa5e) will increase coverage by 1.80%.
The diff coverage is 61.45%.

@@             Coverage Diff              @@
##             master    #1533      +/-   ##
============================================
+ Coverage     57.98%   59.78%   +1.80%     
- Complexity     6108     6230     +122     
============================================
  Files           412      413       +1     
  Lines         33648    33857     +209     
  Branches       4633     4647      +14     
============================================
+ Hits          19511    20242     +731     
+ Misses        12097    11514     -583     
- Partials       2040     2101      +61

Impacted Files	Coverage Δ
...raph/backend/store/cassandra/CassandraMetrics.java	`0.00% <0.00%> (ø)`
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java	`65.30% <ø> (ø)`
...du/hugegraph/backend/cache/CachedBackendStore.java	`9.09% <0.00%> (-0.29%)`	⬇️
...om/baidu/hugegraph/backend/store/BackendStore.java	`80.76% <ø> (ø)`
...hugegraph/backend/store/raft/RaftBackendStore.java	`0.00% <0.00%> (ø)`
...h/backend/store/raft/RaftBackendStoreProvider.java	`0.00% <0.00%> (ø)`
...ugegraph/backend/store/raft/RaftSharedContext.java	`0.00% <0.00%> (ø)`
...m/baidu/hugegraph/backend/tx/GraphTransaction.java	`79.84% <ø> (ø)`
...n/java/com/baidu/hugegraph/config/CoreOptions.java	`99.44% <ø> (-0.02%)`	⬇️
...src/main/java/com/baidu/hugegraph/util/Events.java	`0.00% <ø> (ø)`
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153fa5e...faf6b99. Read the comment docs.

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/AbstractBackendStore.java

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/SystemSchemaStore.java

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/SchemaTransaction.java

hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBTables.java

Change-Id: I2feabace71f266d6be6c2094c30cd19f74ab7f7d

Change-Id: Idb4d3bffcb1cd941bd8a533981d5ab3d479f4069

Change-Id: Ibc4213370d3134ece10eb60830dad25b5bc208b1

Change-Id: I1460e49c4ffb96f49df713a5ae0c845367c67a22

Change-Id: I538714f0b5ee3a8e90aa90db8f43f4b1cc0597d6

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/SystemSchemaStore.java

hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBTables.java

Change-Id: I5c9d65c4ae022cb84592e8f2aa57bd7485cd12e4

github-actions · 2021-08-14T21:12:41Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

Linary · 2021-08-19T06:01:29Z

To updated

github-actions · 2021-09-18T21:11:57Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

javeme · 2022-01-05T09:11:06Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/AbstractBackendStore.java

    }

+    @Override
+    public String storedVersion() {


storedVersion() is only implemented in system store?

javeme · 2022-01-05T09:15:52Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseStore.java

                      "HbaseGraphStore.getCounter()");
        }
+
+        public Session getSession() {


can just use this instead?

javeme · 2022-01-05T12:31:46Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseStore.java

+        public void init() {
+            super.init();
+            super.checkOpened();
+            Session session = super.getSession();


can use Session session = super.sessions.session();

javeme · 2022-01-05T12:32:11Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseStore.java

+        @Override
+        public String storedVersion() {
+            super.checkOpened();
+            Session session = super.getSession();


javeme · 2022-01-05T12:35:11Z

hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseStore.java

+            String driverVersion = this.provider().driverVersion();
+            this.meta.writeVersion(session, driverVersion);
+            LOG.info("Write down the backend version: {}", driverVersion);
+        }


also overwrite truncate() and let it truncate other tables except the meta table

javeme · 2022-02-25T08:25:25Z

...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraStore.java

+        public String storedVersion() {
+            this.checkOpened();
+            CassandraSessionPool.Session session = this.getSession();
+            return this.meta.readVersion(session);


seems server-info can also be stored into meta table

javeme · 2022-04-25T07:57:26Z

...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraStore.java

+        }
+    }
+
+    public static class CassandraSystemStore extends CassandraGraphStore {


prefer to add CassandraMetaStore extends CassandraStore and it don't need to call registerTableManager(HugeType.VERTEX,...), since tasks data in CassandraSystemStore need to be truncate.

Linary force-pushed the system-store branch 2 times, most recently from f1c4fc0 to 4cd1edb Compare July 2, 2021 03:01

javeme reviewed Jul 2, 2021

View reviewed changes

Linary force-pushed the system-store branch 3 times, most recently from 6250a6e to 9541494 Compare July 6, 2021 06:52

Linary force-pushed the system-store branch 3 times, most recently from a80b302 to 68c4724 Compare July 6, 2021 08:15

javeme reviewed Jul 6, 2021

View reviewed changes

javeme previously approved these changes Jul 7, 2021

View reviewed changes

Linary dismissed javeme’s stale review via e521440 July 7, 2021 10:06

Linary force-pushed the system-store branch from ad820c4 to e521440 Compare July 7, 2021 10:06

Linary added 5 commits July 7, 2021 18:32

Add system schema store

707645b

Change-Id: I2feabace71f266d6be6c2094c30cd19f74ab7f7d

Add meta table into system store

6fa4be5

Change-Id: Idb4d3bffcb1cd941bd8a533981d5ab3d479f4069

Add test case for read version

bf81f85

Change-Id: Ibc4213370d3134ece10eb60830dad25b5bc208b1

Let AbstractBackendStore impl default storedVersion()

6b6aaf3

Change-Id: I1460e49c4ffb96f49df713a5ae0c845367c67a22

fix small bug og HugeProject

c8ea317

Change-Id: I538714f0b5ee3a8e90aa90db8f43f4b1cc0597d6

Linary force-pushed the system-store branch from 8125ebc to c8ea317 Compare July 7, 2021 10:32

javeme reviewed Jul 8, 2021

View reviewed changes

add test for SystemSchemaStore

faf6b99

Change-Id: I5c9d65c4ae022cb84592e8f2aa57bd7485cd12e4

Linary force-pushed the system-store branch from 5b2768d to faf6b99 Compare July 15, 2021 09:44

github-actions bot added the inactive label Aug 14, 2021

github-actions bot removed the inactive label Aug 19, 2021

github-actions bot added the inactive label Sep 18, 2021

imbajin removed the inactive label Oct 8, 2021

imbajin added the feature New feature label Oct 8, 2021

javeme reviewed Jan 5, 2022

View reviewed changes

javeme reviewed Feb 25, 2022

View reviewed changes

javeme reviewed Apr 25, 2022

View reviewed changes

Linary closed this May 15, 2022

javeme reopened this May 15, 2022

javeme mentioned this pull request May 20, 2022

Add system schema store #1891

Merged

javeme closed this in #1891 Jun 2, 2022

imbajin deleted the system-store branch October 26, 2023 06:26

imbajin restored the system-store branch October 26, 2023 06:26

imbajin deleted the system-store branch October 26, 2023 06:27

Conversation

Linary commented Jul 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 14, 2021

Uh oh!

Linary commented Aug 19, 2021

Uh oh!

github-actions bot commented Sep 18, 2021

Uh oh!

javeme Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

javeme Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

javeme Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

javeme Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

javeme Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

javeme Feb 25, 2022

Choose a reason for hiding this comment

Uh oh!

javeme Apr 25, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jul 6, 2021 •

edited

Loading