close this pr#1826
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1826 +/- ##
=========================================
Coverage 66.58% 66.58%
+ Complexity 982 980 -2
=========================================
Files 446 446
Lines 37914 37914
Branches 5400 5400
=========================================
Hits 25246 25246
Misses 9963 9963
Partials 2705 2705 Continue to review full report at Codecov.
|
style/checkstyle.xml
Outdated
| <!-- <module name="ClassTypeParameterName">--> | ||
| <!-- <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>--> | ||
| <!-- <message key="name.invalidPattern" value="Class type name ''{0}'' must match pattern ''{1}''."/>--> | ||
| <!-- </module>--> |
There was a problem hiding this comment.
could we consider use low limit check rather than disable all?
like Class<a> / Class<1> is not allowed
There was a problem hiding this comment.
I think we can implement and use the regular expression "[A-Z][a-zA-Z0-9]*$"
There was a problem hiding this comment.
I think we can implement and use the regular expression "[A-Z][a-zA-Z0-9]*$"
Fine
There was a problem hiding this comment.
I had updated checkstyle file.
seagle-yuan
changed the title
3 participants
No description provided.