fix(api): fix remoting rpc server not started#1975
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1975 +/- ##
============================================
+ Coverage 70.46% 70.54% +0.08%
+ Complexity 978 724 -254
============================================
Files 454 454
Lines 39138 39055 -83
Branches 5574 5557 -17
============================================
- Hits 27579 27552 -27
+ Misses 8848 8804 -44
+ Partials 2711 2699 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
两个问题, 第一个是现在官方 raft 的配置里, 就正常无法启动么? (似乎这是不符合预期的, 配置好像在 issue 里, 文档可能没更新) 第二个描述发生的情况是? |
| "serverConfig"); | ||
| serverConfig.buildIfAbsent(); | ||
| if (!serverConfig.getServer().isStarted()) { | ||
| serverConfig.getServer().start(); |
There was a problem hiding this comment.
so we will always start the rpc server?
There was a problem hiding this comment.
it goes here only when raft mode enabled
从issue里找的配置
GraphManager.startRpcServer 这里registerRpcServices时,rockdb not supportsSharedStorage 所以serverConfig未成功addService,exportAll时skip starting RpcServer |
bb66415 to
c455be1
Compare
|
seems |
使用rocksdb作为后端存储+开启raft,不能成功启动,
registerRpcServices时未导出service,rpcserver未启动增加判断,如果server未启动,手动启动