refact(core): update dependencies version & adopt the new analyzer#1989
Merged
javeme merged 3 commits intoapache:masterfrom Oct 26, 2022
Merged
refact(core): update dependencies version & adopt the new analyzer#1989javeme merged 3 commits intoapache:masterfrom
javeme merged 3 commits intoapache:masterfrom
Conversation
javeme
reviewed
Oct 25, 2022
Contributor
javeme
left a comment
javeme
left a comment
There was a problem hiding this comment.
Thanks for your contribution~
hugegraph-core/src/main/java/com/baidu/hugegraph/StandardHugeGraph.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/analyzer/AnalyzerFactory.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1989 +/- ##
============================================
- Coverage 70.54% 70.53% -0.01%
+ Complexity 978 724 -254
============================================
Files 454 454
Lines 39055 39054 -1
Branches 5557 5558 +1
============================================
- Hits 27550 27547 -3
Misses 8806 8806
- Partials 2699 2701 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…lyzer jraft 1.3.9->1.3.11 ohc-core 0.7.0->0.7.4 org.apdplat.word 1.3->1.3.1 hanlp portable-1.5.0->portable-1.8.3 lucene-analyzers-smartcn,lucene-core 7.4.0->8.11.2 jcseg-core->2.2.0 ->2.6.2 lz4-java 1.7.1->1.8.0 eclipse-collections 10.4.0->11.1.0 fastutil 8.1.0->8.4.0 jjwt 0.11.2->0.11.5
jadepeng
force-pushed
the
update-dependencies-version
branch
from
90d9a90 to
7bc8d13
Compare
imbajin
changed the title
imbajin
reviewed
Oct 26, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/analyzer/JcsegAnalyzer.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/analyzer/JcsegAnalyzer.java
Outdated
Show resolved
Hide resolved
| segmentor.reset(new StringReader(text)); | ||
|
|
||
| IWord word; | ||
| while ((word = segmentor.next()) != null) { |
Member
There was a problem hiding this comment.
warn: will the segmentor.next() throw exception if null?
imbajin
approved these changes
Oct 26, 2022
javeme
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And improve analyzer code