refact: clean some code before release#1990
Merged
javeme merged 1 commit intoapache:masterfrom Oct 26, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1990 +/- ##
============================================
+ Coverage 70.54% 70.58% +0.04%
+ Complexity 978 724 -254
============================================
Files 454 454
Lines 39055 39050 -5
Branches 5557 5556 -1
============================================
+ Hits 27550 27565 +15
+ Misses 8806 8789 -17
+ Partials 2699 2696 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
reviewed
Oct 26, 2022
| result.add(elem); | ||
| } | ||
| return result; | ||
| return new HashSet<>(Arrays.asList(elems)); |
Member
There was a problem hiding this comment.
Thanks, and one question is which modules/packages did you check this time? (or u checked all modules?)
If the class file is too much to handle with someone, a simple way is we could divide them with different modules, and others could take the remaining modules
Contributor
Author
There was a problem hiding this comment.
升级core的maven依赖时顺手改的，这块有需要，可以几个人分下
Member
There was a problem hiding this comment.
升级core的maven依赖时顺手改的，这块有需要，可以几个人分下
👌🏻, 那就是说没有系统性的检查一下是吧. 可以按模块分给一下
imbajin
approved these changes
Oct 26, 2022
corgiboygsj
approved these changes
Oct 26, 2022
javeme
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.