Skip to content

refact(dist): avoid script exit while restarting & clean script#2041

Merged
javeme merged 4 commits intomasterfrom
fix-script
Dec 1, 2022
Merged

refact(dist): avoid script exit while restarting & clean script#2041
javeme merged 4 commits intomasterfrom
fix-script

Conversation

@imbajin
Copy link
Copy Markdown
Member

@imbajin imbajin commented Nov 29, 2022

  • fix "restart" not work in hugegraph script
  • clean shell script to avoid error in high-version bash/sh

refer:

and we have a lot of writing way may break the shell rules, and it will lead some unexpected error in high bash/shell version (like the problem when start with java11)

@imbajin imbajin added the shell Issues about shell script label Nov 29, 2022
@imbajin imbajin requested review from coderzc and javeme November 29, 2022 11:12
- fix "restart" not work in script
- clean shell script to avoid error in high-version bash/sh
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2022

Codecov Report

Merging #2041 (e948fe9) into master (927b673) will decrease coverage by 3.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2041      +/-   ##
============================================
- Coverage     65.89%   62.38%   -3.51%     
- Complexity      974      976       +2     
============================================
  Files           482      482              
  Lines         41458    41458              
  Branches       5889     5889              
============================================
- Hits          27319    25864    -1455     
- Misses        11437    13046    +1609     
+ Partials       2702     2548     -154     
Impacted Files Coverage Δ
.../java/org/apache/hugegraph/version/ApiVersion.java 75.00% <ø> (ø)
...java/org/apache/hugegraph/version/CoreVersion.java 80.00% <ø> (ø)
...hugegraph/backend/store/raft/RaftStoreClosure.java 0.00% <0.00%> (-100.00%) ⬇️
...ugegraph/backend/store/rocksdb/RocksDBMetrics.java 0.00% <0.00%> (-85.87%) ⬇️
...gegraph/backend/store/rocksdb/RocksDBFeatures.java 4.16% <0.00%> (-83.34%) ⬇️
...pache/hugegraph/backend/store/raft/RaftResult.java 0.00% <0.00%> (-81.25%) ⬇️
...ache/hugegraph/backend/store/raft/RaftContext.java 0.00% <0.00%> (-80.96%) ⬇️
...hugegraph/backend/store/raft/RaftBackendStore.java 0.00% <0.00%> (-75.27%) ⬇️
...hugegraph/backend/store/raft/rpc/RpcForwarder.java 0.00% <0.00%> (-69.50%) ⬇️
.../backend/store/raft/rpc/StoreCommandProcessor.java 0.00% <0.00%> (-65.22%) ⬇️
... and 64 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin
Copy link
Copy Markdown
Member Author

imbajin commented Nov 29, 2022

and I'll fix the script problem left in #2024 in next PR

@javeme javeme merged commit 2251adf into master Dec 1, 2022
@javeme javeme deleted the fix-script branch December 1, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shell Issues about shell script

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants