Conversation
imbajin
force-pushed
the
before-release
branch
from
c31bb25 to
5b02e2e
Compare
imbajin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
Coverage 68.40% 68.40%
+ Complexity 978 677 -301
==========================================
Files 481 481
Lines 39749 39749
Branches 5582 5582
==========================================
+ Hits 27189 27191 +2
Misses 9934 9934
+ Partials 2626 2624 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zyxxoo
previously approved these changes
Dec 7, 2022
javeme
reviewed
Dec 7, 2022
| # commit & push files | ||
| svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" | ||
|
|
||
| echo "Finished all, please check all steps in script manually again! " |
Member
Author
There was a problem hiding this comment.
@coderzc avoid “！” parsed in the end of string，it may lead some unexpected behavior (like this case)
echo "${a} !" or echo "${a} is good!" are also wrong :)
but here，it's fine to ignore it, just a reminder for others using '!' in the string-end
| svn add "${RELEASE_VERSION}" | ||
| # check status again | ||
| svn status | ||
| # commit & push files |
pom.xml
Outdated
|
|
||
| <mailingLists> | ||
| <mailingList> | ||
| <name>Development List</name> |
Member
Author
There was a problem hiding this comment.
keep the origin is also fine, the xml tag is mailingList already, and other apache repo has the similar name:
however, seems better to use developer instead of development? 😺
imbajin
commented
Dec 8, 2022
Comment on lines
+130
to
+131
| * 1. Get all newVertices' ID & combine first | ||
| * 2. Get all oldVertices & update |
Contributor
There was a problem hiding this comment.
on javadoc & is html's keyword，so there are error when complile，& represent & in html
coderzc
reviewed
Dec 9, 2022
| ##### 4.3 commit to svn | ||
| # check status first | ||
| svn status | ||
| svn add --parents apache-${REPO}-* |
Member
There was a problem hiding this comment.
Suggested change
| svn add --parents apache-${REPO}-* | |
| svn add --parents ${RELEASE_VERSION}/apache-${REPO}-* |
javeme
previously approved these changes
Dec 10, 2022
zyxxoo
force-pushed
the
before-release
branch
2 times, most recently
from
bf2cbbd to
4ca939a
Compare
imbajin
commented
Dec 10, 2022
| rm -rfv dist && mkdir -p dist/apache-${REPO} | ||
|
|
||
| # step1: package the source code | ||
| cd ../../ |
Member
Author
There was a problem hiding this comment.
also add || exit to avoid error
zyxxoo
force-pushed
the
before-release
branch
from
dff6c63 to
aa1397b
Compare
zyxxoo
force-pushed
the
before-release
branch
from
aa1397b to
8781f1b
Compare
coderzc
previously approved these changes
Dec 14, 2022
zyxxoo
approved these changes
Dec 14, 2022
javeme
approved these changes
Dec 14, 2022
| </prerequisites> | ||
| <developers> | ||
| <developer> | ||
| <id>Apache Hugegraph(incubating)</id> |
| <exclude>GROUPS</exclude> | ||
| <exclude>OWNERS</exclude> | ||
| <!-- GitHub --> | ||
| <!-- Git & GitHub --> |
Contributor
There was a problem hiding this comment.
there is a space in the end of GitHub[ ]
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zyxxoo continue & test the release with this PR (amend 4th commit to complete it)
Remember rename current branch to
release-1.0.0for script running:git branch -m before-release release-1.0.0and use
rebase and mergefor it