Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 888 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 670 | 3 | 215 | 0 |
Click to see the invalid file list
- hugegraph-core/src/main/java/org/apache/hugegraph/type/Nameable.java
- hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java
- hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java
hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2100 +/- ##
=============================================
- Coverage 68.70% 48.01% -20.69%
+ Complexity 979 379 -600
=============================================
Files 479 479
Lines 39655 39655
Branches 5578 5578
=============================================
- Hits 27243 19041 -8202
- Misses 9770 18485 +8715
+ Partials 2642 2129 -513
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
previously approved these changes
Jan 31, 2023
zyxxoo
changed the title
imbajin
reviewed
Feb 1, 2023
Comment on lines
+11
to
+28
| // NOTICE file corresponding to the section 4d of The Apache License, | ||
| // Version 2.0, in this case for JanusGraph | ||
| // ------------------------------------------------------------------ | ||
|
|
||
| JanusGraph | ||
| Copyright (C) 2002, 2016, Oracle and/or its affiliates. All rights reserved. |
Member
There was a problem hiding this comment.
shall we add it in binary release NOTICE file?
Contributor
Author
There was a problem hiding this comment.
yes, i have added it in binary release
zyxxoo
commented
Feb 2, 2023
hugegraph-dist/release-docs/LICENSE
Outdated
| (Apache License, Version 2.0) * Apache Log4j Core (org.apache.logging.log4j:log4j-core:2.17.1 - https://logging.apache.org/log4j/2.x/log4j-core/) | ||
| (Apache License, Version 2.0) * Apache Log4j SLF4J Binding (org.apache.logging.log4j:log4j-slf4j-impl:2.17.1 - https://logging.apache.org/log4j/2.x/log4j-slf4j-impl/) | ||
| (Apache License, Version 2.0) * Apache Thrift (org.apache.thrift:libthrift:0.9.2 - http://thrift.apache.org) | ||
| (Apache License, Version 2.0) * JanusGraph (https://github.com/apache/tinkerpop) |
Contributor
Author
There was a problem hiding this comment.
@WillemJiang
hi,
Our source code refers to the janusGraph source file, but doesn't refer the jar dependency.
I have modified the source license & notice and binary license & notice to declare it, but I'm a little unsure if i write the binary license in the write way. The binary artifact doesn't have java source file. We don't refer to the janusGraph's binary artifact (we only copy its source file, which becomes class file in binary artifact).
For example:
we source code refers to the A project a.java source file
- Wether the binary license needs to declare"a.class from https://githu.com/A"
- If we don't refer to A.jar (only source file), do we write "A (https://github.com/A" or "A (org.A:A:0.0.1 - https://github.com/A)"?
- If archive file path is different between source path and binary artifact, can we only copy source license to binary license?
I am looking forward to your suggestions to write these situations better.
Thanks a lot
javeme
previously approved these changes
Feb 6, 2023
Comment on lines
+11
to
+28
| // NOTICE file corresponding to the section 4d of The Apache License, | ||
| // Version 2.0, in this case for JanusGraph | ||
| // ------------------------------------------------------------------ | ||
|
|
||
| JanusGraph | ||
| Copyright (C) 2002, 2016, Oracle and/or its affiliates. All rights reserved. |
imbajin
reviewed
Feb 7, 2023
javeme
approved these changes
Feb 7, 2023
imbajin
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference: #1632