Skip to content

feat: support disable RocksDB auto-compaction by configuration #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VGalaxies merged 2 commits into from
Jul 16, 2024
Merged

feat: support disable RocksDB auto-compaction by configuration #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a6052
#2583
haohao0103 Jul 15, 2024
e3377df
close #2583
haohao0103 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...re/hg-store-rocksdb/src/main/java/org/apache/hugegraph/rocksdb/access/RocksDBOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ public class RocksDBOptions extends OptionHolder {
disallowEmpty(),
"rocksdb-snapshot"
);
public static final ConfigOption<Boolean> DISABLE_AUTO_COMPACTION =
new ConfigOption<>(
"rocksdb.disable_auto_compaction",
"Set disable auto compaction.",
disallowEmpty(),
false
);
public static final ConfigConvOption<String, CompactionStyle> COMPACTION_STYLE =
new ConfigConvOption<>(
"rocksdb.compaction_style",
Expand Down
3 changes: 3 additions & 0 deletions ...re/hg-store-rocksdb/src/main/java/org/apache/hugegraph/rocksdb/access/RocksDBSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,9 @@ private void openRocksDB(String dbDataPath, long version) {
List<byte[]> columnFamilyBytes = RocksDB.listColumnFamilies(new Options(), dbPath);

ColumnFamilyOptions cfOptions = new ColumnFamilyOptions();
if (hugeConfig.get(RocksDBOptions.DISABLE_AUTO_COMPACTION)) {
cfOptions.setDisableAutoCompactions(true);
}
RocksDBSession.initOptions(this.hugeConfig, null, null, cfOptions, cfOptions);

if (columnFamilyBytes.size() > 0) {
Expand Down