Skip to content

refact(server): enlarge bytes write limit & remove param big when encode/decode string id length#2622

Merged
imbajin merged 20 commits intomasterfrom
limit-conf
Aug 10, 2024
Merged

refact(server): enlarge bytes write limit & remove param big when encode/decode string id length#2622
imbajin merged 20 commits intomasterfrom
limit-conf

Conversation

@VGalaxies
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies commented Aug 6, 2024

As title, change limit:

  • vid max to 16KB
  • eid max to 64kb (128k as backup)
  • property max to 10MB (keep consistent)

fix #1593 #2291

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 6, 2024
@VGalaxies VGalaxies requested a review from imbajin August 6, 2024 09:53
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.17%. Comparing base (7df736a) to head (0fd517c).

Files Patch % Lines
...ache/hugegraph/backend/serializer/BytesBuffer.java 65.21% 1 Missing and 7 partials ⚠️
...g/apache/hugegraph/backend/cache/OffheapCache.java 80.00% 2 Missing ⚠️
.../main/java/org/apache/hugegraph/backend/id/Id.java 0.00% 0 Missing and 1 partial ⚠️
...hugegraph/backend/serializer/BinarySerializer.java 50.00% 0 Missing and 1 partial ⚠️
...va/org/apache/hugegraph/structure/HugeElement.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2622      +/-   ##
============================================
- Coverage     48.70%   45.17%   -3.54%     
+ Complexity      708      583     -125     
============================================
  Files           729      718      -11     
  Lines         59508    58434    -1074     
  Branches       7659     7491     -168     
============================================
- Hits          28984    26398    -2586     
- Misses        27628    29318    +1690     
+ Partials       2896     2718     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 6, 2024
@imbajin imbajin changed the title chore(server): enlarge bytes write limit & encode string id length with 2 bits by default refact(server): enlarge bytes write limit & encode string id length with 2 bits Aug 7, 2024
@imbajin imbajin added this to the 1.5.0 milestone Aug 7, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@VGalaxies VGalaxies changed the title refact(server): enlarge bytes write limit & encode string id length with 2 bits refact(server): enlarge bytes write limit & remove param big when encode/decode string id length Aug 7, 2024
@VGalaxies VGalaxies requested a review from imbajin August 8, 2024 13:16
imbajin
imbajin previously approved these changes Aug 9, 2024
Copy link
Copy Markdown
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@imbajin imbajin self-requested a review August 10, 2024 08:54
@imbajin imbajin merged commit df921e9 into master Aug 10, 2024
@imbajin imbajin deleted the limit-conf branch August 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] hugegraph-loader导入数据报错PARSE ERROR: Vertex id length limit is '128'

3 participants