Skip to content

chore: set the skipCommonsTests property to true by default #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VGalaxies merged 1 commit into from
Sep 1, 2024
Merged

chore: set the skipCommonsTests property to true by default #2651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/commons-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ jobs:

- name: Run common test
run: |
mvn test -pl hugegraph-commons/hugegraph-common -Dtest=UnitTestSuite
mvn test -pl hugegraph-commons/hugegraph-common -Dtest=UnitTestSuite -DskipCommonsTests=false

- name: Run rpc test
run: |
mvn test -pl hugegraph-commons/hugegraph-rpc -Dtest=UnitTestSuite
mvn test -pl hugegraph-commons/hugegraph-rpc -Dtest=UnitTestSuite -DskipCommonsTests=false

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3.0.0
Expand Down
2 changes: 1 addition & 1 deletion hugegraph-commons/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
<sun.xml.version>3.0.2</sun.xml.version>
<checkstyle.plugin.version>3.1.2</checkstyle.plugin.version>
<checkstyle.version>8.45</checkstyle.version>
<skipCommonsTests>false</skipCommonsTests>
<skipCommonsTests>true</skipCommonsTests>
</properties>

<modules>
Expand Down
2 changes: 1 addition & 1 deletion hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test-for-raft.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export HUGEGRAPH_PASSWORD=pa
$RAFT_TOOLS --set-leader "hugegraph" "$RAFT_LEADER"

# run api-test
mvn test -pl hugegraph-server/hugegraph-test -am -P api-test,$BACKEND -DskipCommonsTests=true || (cat $RAFT1_DIR/logs/hugegraph-server.log && exit 1)
mvn test -pl hugegraph-server/hugegraph-test -am -P api-test,$BACKEND || (cat $RAFT1_DIR/logs/hugegraph-server.log && exit 1)

$TRAVIS_DIR/build-report.sh $BACKEND $JACOCO_PORT $REPORT_FILE

Expand Down
2 changes: 1 addition & 1 deletion hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ authentication: {
$TRAVIS_DIR/start-server.sh $SERVER_DIR $BACKEND $JACOCO_PORT || (cat $SERVER_DIR/logs/hugegraph-server.log && exit 1)

# run api-test
mvn test -pl hugegraph-server/hugegraph-test -am -P api-test,$BACKEND -DskipCommonsTests=true || (cat $SERVER_DIR/logs/hugegraph-server.log && exit 1)
mvn test -pl hugegraph-server/hugegraph-test -am -P api-test,$BACKEND || (cat $SERVER_DIR/logs/hugegraph-server.log && exit 1)

$TRAVIS_DIR/build-report.sh $BACKEND $JACOCO_PORT $REPORT_FILE

Expand Down
2 changes: 1 addition & 1 deletion hugegraph-server/hugegraph-dist/src/assembly/travis/run-core-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ set -ev

BACKEND=$1

mvn test -pl hugegraph-server/hugegraph-test -am -P core-test,$BACKEND -DskipCommonsTests=true
mvn test -pl hugegraph-server/hugegraph-test -am -P core-test,$BACKEND
4 changes: 2 additions & 2 deletions hugegraph-server/hugegraph-dist/src/assembly/travis/run-tinkerpop-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ BACKEND=$1
SUITE=$2

if [[ "$SUITE" == "structure" || "$SUITE" == "tinkerpop" ]]; then
mvn test -pl hugegraph-server/hugegraph-test -am -P tinkerpop-structure-test,$BACKEND -DskipCommonsTests=true
mvn test -pl hugegraph-server/hugegraph-test -am -P tinkerpop-structure-test,$BACKEND
fi

if [[ "$SUITE" == "process" || "$SUITE" == "tinkerpop" ]]; then
mvn test -pl hugegraph-server/hugegraph-test -am -P tinkerpop-process-test,$BACKEND -DskipCommonsTests=true
mvn test -pl hugegraph-server/hugegraph-test -am -P tinkerpop-process-test,$BACKEND
fi
2 changes: 1 addition & 1 deletion hugegraph-server/hugegraph-dist/src/assembly/travis/run-unit-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ set -ev
BACKEND=$1

if [[ "$BACKEND" == "memory" ]]; then
mvn test -pl hugegraph-server/hugegraph-test -am -P unit-test -DskipCommonsTests=true
mvn test -pl hugegraph-server/hugegraph-test -am -P unit-test
fi