Throw exception if exceeds 80w without paging#414
Closed
Conversation
resolved: #360 Change-Id: I46c7a61df21d6902aba6c0c965e8f63aa3b76fe2
javeme
requested changes
Mar 28, 2019
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/VerticesAPI.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/EdgesAPI.java
Outdated
Show resolved
Hide resolved
Change-Id: Ia89e0578306091fc0cd54fd7c64a91b2b0881b9f
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
============================================
- Coverage 70.16% 70.13% -0.04%
+ Complexity 3274 3271 -3
============================================
Files 208 208
Lines 16050 16050
Branches 2301 2301
============================================
- Hits 11262 11256 -6
- Misses 3536 3543 +7
+ Partials 1252 1251 -1
Continue to review full report at Codecov.
|
javeme
requested changes
Mar 28, 2019
hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/EdgesAPI.java
Outdated
Show resolved
Hide resolved
Change-Id: I6acd4fc29acfd2aa03567fc612adcaab2bbee593
javeme
requested changes
Mar 28, 2019
Change-Id: I99d5ac692d54266dbff863365245ca8491a00008
javeme
requested changes
Apr 2, 2019
| query.page(page); | ||
| if (query.paging()) { | ||
| query.limit(SCAN_LIMIT); | ||
| query.limit(SCAN_PAGE_LIMIT); |
Contributor
There was a problem hiding this comment.
add page_limit parameter and set default value as SCAN_PAGE_LIMIT
rename SCAN_PAGE_LIMIT to SCAN_DEFAULT_PAGE_LIMIT
Contributor
Author
|
abandon due to included in #428 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved: #360
Change-Id: I46c7a61df21d6902aba6c0c965e8f63aa3b76fe2