Skip to content

Throw exception if exceeds 80w without paging#414

Closed
zhoney wants to merge 4 commits intomasterfrom
scan-improve
Closed

Throw exception if exceeds 80w without paging#414
zhoney wants to merge 4 commits intomasterfrom
scan-improve

Conversation

@zhoney
Copy link
Copy Markdown
Contributor

@zhoney zhoney commented Mar 28, 2019

resolved: #360

Change-Id: I46c7a61df21d6902aba6c0c965e8f63aa3b76fe2

resolved: #360

Change-Id: I46c7a61df21d6902aba6c0c965e8f63aa3b76fe2
Change-Id: Ia89e0578306091fc0cd54fd7c64a91b2b0881b9f
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2019

Codecov Report

Merging #414 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #414      +/-   ##
============================================
- Coverage     70.16%   70.13%   -0.04%     
+ Complexity     3274     3271       -3     
============================================
  Files           208      208              
  Lines         16050    16050              
  Branches       2301     2301              
============================================
- Hits          11262    11256       -6     
- Misses         3536     3543       +7     
+ Partials       1252     1251       -1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/baidu/hugegraph/task/TaskManager.java 60.86% <0%> (-4.35%) 10% <0%> (-1%)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 70.87% <0%> (-0.65%) 60% <0%> (ø)
...va/com/baidu/hugegraph/backend/cache/RamCache.java 67.06% <0%> (-0.41%) 41% <0%> (-1%)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.39% <0%> (-0.16%) 145% <0%> (-1%)
...a/com/baidu/hugegraph/backend/query/Condition.java 62.96% <0%> (+0.52%) 20% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d8d8f...45f9a99. Read the comment docs.

Change-Id: I6acd4fc29acfd2aa03567fc612adcaab2bbee593
Change-Id: I99d5ac692d54266dbff863365245ca8491a00008
query.page(page);
if (query.paging()) {
query.limit(SCAN_LIMIT);
query.limit(SCAN_PAGE_LIMIT);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add page_limit parameter and set default value as SCAN_PAGE_LIMIT
rename SCAN_PAGE_LIMIT to SCAN_DEFAULT_PAGE_LIMIT

@zhoney
Copy link
Copy Markdown
Contributor Author

zhoney commented Apr 2, 2019

abandon due to included in #428

@zhoney zhoney closed this Apr 2, 2019
@zhoney zhoney deleted the scan-improve branch April 2, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support paging for scan API

2 participants