add conf entry mysql.engine to change storage engine of mysql, defaul…#553
Closed
wenzhenghu wants to merge 1 commit intoapache:masterfrom
wenzhenghu:myrocks
Closed
add conf entry mysql.engine to change storage engine of mysql, defaul…#553wenzhenghu wants to merge 1 commit intoapache:masterfrom wenzhenghu:myrocks
wenzhenghu wants to merge 1 commit intoapache:masterfrom
wenzhenghu:myrocks
Conversation
…t innodb, could change to rocksdb..
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
===========================================
+ Coverage 70.19% 70.2% +<.01%
Complexity 3418 3418
===========================================
Files 216 216
Lines 16461 16470 +9
Branches 2351 2350 -1
===========================================
+ Hits 11555 11562 +7
- Misses 3650 3654 +4
+ Partials 1256 1254 -2
Continue to review full report at Codecov.
|
javeme
requested changes
Jun 4, 2019
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlOptions.java
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlOptions.java
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlStore.java
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlTable.java
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlTable.java
Show resolved
Hide resolved
Contributor
|
reopened from https://github.com/hugegraph/hugegraph/pull/555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add conf entry mysql.engine to change storage engine of mysql
default innodb, could change to rocksdb, but not myisam, as hugegraph will create large index that myisam could not support ("Specified key was too long; max key length is 1000 bytes")