Skip to content

add conf entry mysql.engine to change storage engine of mysql, defaul…#553

Closed
wenzhenghu wants to merge 1 commit intoapache:masterfrom
wenzhenghu:myrocks
Closed

add conf entry mysql.engine to change storage engine of mysql, defaul…#553
wenzhenghu wants to merge 1 commit intoapache:masterfrom
wenzhenghu:myrocks

Conversation

@wenzhenghu
Copy link
Copy Markdown
Contributor

add conf entry mysql.engine to change storage engine of mysql
default innodb, could change to rocksdb, but not myisam, as hugegraph will create large index that myisam could not support ("Specified key was too long; max key length is 1000 bytes")

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2019

Codecov Report

Merging #553 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #553      +/-   ##
===========================================
+ Coverage     70.19%   70.2%   +<.01%     
  Complexity     3418    3418              
===========================================
  Files           216     216              
  Lines         16461   16470       +9     
  Branches       2351    2350       -1     
===========================================
+ Hits          11555   11562       +7     
- Misses         3650    3654       +4     
+ Partials       1256    1254       -2
Impacted Files Coverage Δ Complexity Δ
...du/hugegraph/backend/store/mysql/MysqlOptions.java 95.65% <100%> (+0.41%) 3 <0> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 73.25% <100%> (-0.16%) 34 <0> (ø)
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 77.37% <100%> (+0.6%) 71 <2> (+1) ⬆️
...ain/java/com/baidu/hugegraph/task/TaskManager.java 60.86% <0%> (-4.35%) 10% <0%> (-1%)
...n/java/com/baidu/hugegraph/task/TaskScheduler.java 51.45% <0%> (-1.25%) 26% <0%> (-1%)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 80% <0%> (+0.47%) 146% <0%> (ø) ⬇️
...u/hugegraph/backend/store/mysql/MysqlSessions.java 70.73% <0%> (+0.6%) 18% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a3c35...d0fb362. Read the comment docs.

@wenzhenghu wenzhenghu closed this Jun 5, 2019
@wenzhenghu wenzhenghu deleted the myrocks branch June 5, 2019 01:49
@javeme
Copy link
Copy Markdown
Contributor

javeme commented Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants