Fix the nullability of snapshot-id on AssertRefSnapshotId#103
Merged
Fokko merged 1 commit intoapache:mainfrom Oct 25, 2023
Merged
Fix the nullability of snapshot-id on AssertRefSnapshotId#103Fokko merged 1 commit intoapache:mainfrom
snapshot-id on AssertRefSnapshotId#103Fokko merged 1 commit intoapache:mainfrom
Conversation
It is not super clear from the current structure: https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.py#L304-L329 This is because I had to deconstruct the object. It would be great to get apache/iceberg#7710 in
nastra
approved these changes
Oct 25, 2023
amogh-jahagirdar
approved these changes
Oct 25, 2023
Contributor
Author
|
Thanks for the prompt review @nastra & @amogh-jahagirdar 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not super clear from the current structure:
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.py#L304-L329
This is because I had to deconstruct the object. It would be great to get apache/iceberg#7710 in.