Fix pa.Schema type annotations in schema_to_pyarrow#3261
Merged
geruh merged 1 commit intoapache:mainfrom Apr 21, 2026
Merged
Conversation
rambleraptor
approved these changes
Apr 21, 2026
Contributor
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
Great find! Thanks for doing this
geruh
approved these changes
Apr 21, 2026
Member
geruh
left a comment
geruh
left a comment
There was a problem hiding this comment.
lgtm, schema is a factory function!
geruh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
schema_for_pyarrowreturn type ispa.schemabut shouldpa.Schema.pa.schemais the factory method (pyarrow docs) whereaspa.Schemais the class it constructs (pyarrow docs).Are these changes tested?
Just a type change.
make lintpasses.Are there any user-facing changes?
No