Convert the Logical to Physical map to a visitor#43
Merged
Fokko merged 3 commits intoapache:mainfrom Oct 7, 2023
Merged
Conversation
I noticed that the FixedType was missing.
rdblue
reviewed
Oct 6, 2023
| return visit(iceberg_type, _PRIMITIVE_TO_PHYISCAL_TYPE_VISITOR) | ||
|
|
||
|
|
||
| class PrimitiveToPyhsicalType(SchemaVisitorPerPrimitiveType[str]): |
Contributor
There was a problem hiding this comment.
Typo: Pyhsical (unless maybe that's how it's spelled in the python community)
rdblue
reviewed
Oct 6, 2023
| return "BYTE_ARRAY" | ||
|
|
||
| def visit_decimal(self, decimal_type: DecimalType) -> str: | ||
| raise ValueError("unknown") |
Contributor
There was a problem hiding this comment.
We could convert to FIXED_LEN_BYTE_ARRAY or INT64 or INT32 based on the precision, right?
Contributor
Author
There was a problem hiding this comment.
I would say FIXED_LEN_BYTE_ARRAY. This visitor is just to double-check that we get the type that we expect.
rdblue
approved these changes
Oct 6, 2023
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
Looks good overall, but I'd fix the typo before merging.
Fokko
force-pushed
the
fd-convert-map-to-visitor
branch
from
9b4efa1 to
c33eb7a
Compare
…rt-map-to-visitor
Contributor
Author
|
Thanks @rdblue for the quick review! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the FixedType was missing.