Fix the TableIdentifier #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
approved these changes
Oct 7, 2023
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Just a nit, but overall LGTM!
tests/test_integration.py
Outdated
| transaction.remove_properties("abc") | ||
|
|
||
| assert table.properties == {} | ||
| assert table.properties == {'write.parquet.compression-codec': 'zstd'} |
Contributor
There was a problem hiding this comment.
Nit: I suppose we could just define a constant default properties set with the compression codec set, and then just use that in all the tests except the table properties test. The tables property test would be the union of the DEFAULT properties and the "abc" property.
Contributor
Author
There was a problem hiding this comment.
Good point @amogh-jahagirdar Updated the code.
Can't wait for the new dictionary merge code d1 | d2
Fokko
referenced
this pull request
in Fokko/iceberg-python
Oct 15, 2023
* Fix the TableIdentifier * Make the rest of the tests happy * Add default properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were sending a table identifier before in
['accounting', 'tax', 'invoices'], but it has to be{'namespace': ['accounting, 'tax'], 'name': 'invoices'}😭